Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Updating to Typescript 2.5.2 produces error #1247

Closed
juergenr opened this issue Sep 1, 2017 · 7 comments
Closed

Updating to Typescript 2.5.2 produces error #1247

juergenr opened this issue Sep 1, 2017 · 7 comments

Comments

@juergenr
Copy link

juergenr commented Sep 1, 2017

Typescript <=2.4.2 and 2.5.0 works fine.
Typescript >=2.5.1 gives following error:

ERROR in [at-loader] ./ClientApp/boot.server.ts:25:18 
    TS2339: Property 'onError' does not exist on type '{}'.
@Trapulo
Copy link

Trapulo commented Sep 1, 2017

same here

nothing easy in this project :(

@MarkPieszak
Copy link
Contributor

It depends on which template you're using, but TypeScript isn't something that can be easily updated so quickly because all of the libraries and frameworks you're working with might not have upgraded to reflect the changes they made. "Minor" versions in TS seem to have breaking changes, even if only minor ones unfortunately. 😐

@juergenr
Copy link
Author

juergenr commented Sep 2, 2017

I tested with different templates, including most current.
I also updated all other package to the most current version.

I think it's only one small change in line
zone.onError.subscribe(errorInfo => reject(errorInfo));
of boot-server.ts to get it running, with current typscript 2.5.2.

Thanks for the great project!

@mmgrt
Copy link

mmgrt commented Sep 4, 2017

Had this issue after updating my packages -angular template-, fixed it by defining zone along with it's type NgZone like this:
const zone: NgZone = moduleRef.injector.get(NgZone);

in the boot.server.ts file.

@juergenr
Copy link
Author

juergenr commented Sep 5, 2017

Making zone typesafe solves the issue.
Runing current typscript 2.5.2 works now!
Thank you @mmgrt!

@christos-kostopoulos
Copy link

const zone:any = moduleRef.injector.get(NgZone);

@SteveSandersonMS
Copy link
Member

Thanks for letting us know.

When we update the template sources to TypeScript 2.5.2+ this issue will inevitably surface and we'll use one of your suggested resolutions.

Closing for now because there's no action to take on it (at least, not prior to updating to TypeScript 2.5.2).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants