Review feedback 2

Author: troydai

src/Microsoft.AspNet.Server.Kestrel/Http/Frame.cs

@@ -116,24 +116,19 @@ public void Reset()
             DuplexStream = null;
 
             var httpConnectionFeature = this as IHttpConnectionFeature;
-            if (httpConnectionFeature != null)
-            {
-                if (_remoteEndPoint != null)
-                {
-                    httpConnectionFeature.RemoteIpAddress = _remoteEndPoint.Address;
-                    httpConnectionFeature.RemotePort = _remoteEndPoint.Port;
-                }
+            httpConnectionFeature.RemoteIpAddress = _remoteEndPoint?.Address;
+            httpConnectionFeature.RemotePort = _remoteEndPoint?.Port ?? 0;
 
-                if (_localEndPoint != null)
-                {
-                    httpConnectionFeature.LocalIpAddress = _localEndPoint.Address;
-                    httpConnectionFeature.LocalPort = _localEndPoint.Port;
-                }
+            httpConnectionFeature.LocalIpAddress = _localEndPoint?.Address;
+            httpConnectionFeature.LocalPort = _localEndPoint?.Port ?? 0;
 
-                if (_remoteEndPoint != null && _localEndPoint != null)
-                {
-                    httpConnectionFeature.IsLocal = _remoteEndPoint.Address.Equals(_localEndPoint.Address);
-                }
+            if (_remoteEndPoint != null && _localEndPoint != null)
+            {
+                httpConnectionFeature.IsLocal = _remoteEndPoint.Address.Equals(_localEndPoint.Address);
+            }
+            else
+            {
+                httpConnectionFeature.IsLocal = false;
             }
         }
 
@@ -159,7 +154,7 @@ public void Start()
         /// <summary>
         /// Should be called when the server wants to initiate a shutdown. The Task returned will
         /// become complete when the RequestProcessingAsync function has exited. It is expected that
-        /// Stop will be called on all active connections, and Task.WaitAll() will be called on every 
+        /// Stop will be called on all active connections, and Task.WaitAll() will be called on every
         /// return value.
         /// </summary>
         public Task Stop()
@@ -172,7 +167,7 @@ public Task Stop()
         }
 
         /// <summary>
-        /// Primary loop which consumes socket input, parses it for protocol framing, and invokes the 
+        /// Primary loop which consumes socket input, parses it for protocol framing, and invokes the
         /// application delegate for as long as the socket is intended to remain open.
         /// The resulting Task from this loop is preserved in a field which is used when the server needs
         /// to drain and close all currently active connections.
@@ -767,7 +762,7 @@ public static bool TakeMessageHeaders(SocketInput input, FrameRequestHeaders req
 
                         if (chSecond != '\n')
                         {
-                            // "\r" was all by itself, move just after it and try again 
+                            // "\r" was all by itself, move just after it and try again
                             scan = endValue;
                             scan.Take();
                             continue;
@@ -776,7 +771,7 @@ public static bool TakeMessageHeaders(SocketInput input, FrameRequestHeaders req
                         var chThird = scan.Peek();
                         if (chThird == ' ' || chThird == '\t')
                         {
-                            // special case, "\r\n " or "\r\n\t". 
+                            // special case, "\r\n " or "\r\n\t".
                             // this is considered wrapping"linear whitespace" and is actually part of the header value
                             // continue past this for the next
                             wrapping = true;

src/Microsoft.AspNet.Server.Kestrel/Networking/SockAddr.cs

@@ -34,12 +34,12 @@ public IPEndPoint GetIPEndPoint()
             // 0000 0000 0000 0000
             //
             // Example 2: 10.135.34.141:39178 when adopt dual-stack sockets, IPv4 is mapped to IPv6
-            // 
+            //
             // 0000 0000 0a99 0017  => The port representation are the same
             // 0000 0000 0000 0000
-            // 8d22 870a ffff 0000  => IPv4 occupies the last 32 bit: 0A.87.22.8d is the actual address. 
+            // 8d22 870a ffff 0000  => IPv4 occupies the last 32 bit: 0A.87.22.8d is the actual address.
             // 0000 0000 0000 0000
-            // 
+            //
             // Example 3: 10.135.34.141:12804, not dual-stack sockets
             // 8d22 870a fd31 0002  => sa_family == AF_INET (02)
             // 0000 0000 0000 0000
@@ -81,7 +81,7 @@ public IPEndPoint GetIPEndPoint()
 
         private bool IsIPv4MappedToIPv6()
         {
-            // If the IPAddress is an IPv4 mapped to IPv6, returns the IPv4 representation instead.
+            // If the IPAddress is an IPv4 mapped to IPv6, return the IPv4 representation instead.
             // For example [::FFFF:127.0.0.1] will be transform to IPAddress of 127.0.0.1
             if (_field1 != 0)
             {