If request aborted and no response sent, log status code '0' when disposing context.

Author: Cesar Blum Silveira

src/Microsoft.AspNetCore.Server.Kestrel/Internal/Http/Frame.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Net;

src/Microsoft.AspNetCore.Server.Kestrel/Internal/Http/FrameOfT.cs

@@ -91,24 +91,25 @@ public override async Task RequestProcessingAsync()
                         var context = _application.CreateContext(this);
                         try
                         {
-                            await _application.ProcessRequestAsync(context).ConfigureAwait(false);
+                            try
+                            {
+                                await _application.ProcessRequestAsync(context).ConfigureAwait(false);
 
-                            var responseHeaders = FrameResponseHeaders;
-                            if (!responseHeaders.HasTransferEncoding &&
-                                responseHeaders.HasContentLength &&
-                                _responseBytesWritten < responseHeaders.HeaderContentLengthValue.Value)
+                                var responseHeaders = FrameResponseHeaders;
+                                if (!responseHeaders.HasTransferEncoding &&
+                                    responseHeaders.HasContentLength &&
+                                    _responseBytesWritten < responseHeaders.HeaderContentLengthValue.Value)
+                                {
+                                    _keepAlive = false;
+                                    ReportApplicationError(new InvalidOperationException(
+                                        $"Response Content-Length mismatch: too few bytes written ({_responseBytesWritten} of {responseHeaders.HeaderContentLengthValue.Value})."));
+                                }
+                            }
+                            catch (Exception ex)
                             {
-                                _keepAlive = false;
-                                ReportApplicationError(new InvalidOperationException(
-                                    $"Response Content-Length mismatch: too few bytes written ({_responseBytesWritten} of {responseHeaders.HeaderContentLengthValue.Value})."));
+                                ReportApplicationError(ex);
                             }
-                        }
-                        catch (Exception ex)
-                        {
-                            ReportApplicationError(ex);
-                        }
-                        finally
-                        {
+
                             // Trigger OnStarting if it hasn't been called yet and the app hasn't
                             // already failed. If an OnStarting callback throws we can go through
                             // our normal error handling in ProduceEnd.
@@ -125,40 +126,43 @@ public override async Task RequestProcessingAsync()
                                 await FireOnCompleted();
                             }
 
-                            try
+                            // If _requestAbort is set, the connection has already been closed.
+                            if (Volatile.Read(ref _requestAborted) == 0)
                             {
-                                // If _requestAbort is set, the connection has already been closed.
-                                if (Volatile.Read(ref _requestAborted) == 0)
-                                {
-                                    ResumeStreams();
+                                ResumeStreams();
 
-                                    if (_keepAlive)
-                                    {
-                                        // Finish reading the request body in case the app did not.
-                                        await messageBody.Consume();
-                                    }
+                                if (_keepAlive)
+                                {
+                                    // Finish reading the request body in case the app did not.
+                                    await messageBody.Consume();
                                 }
 
                                 // ProduceEnd() must be called before _application.DisposeContext(), to ensure
                                 // HttpContext.Response.StatusCode is correctly set when
                                 // IHttpContextFactory.Dispose(HttpContext) is called.
                                 await ProduceEnd();
                             }
-                            finally
+                            else if (!HasResponseStarted)
                             {
-                                _application.DisposeContext(context, _applicationException);
+                                // If the request was aborted and no response was sent, there's no
+                                // meaningful status code to log.
+                                StatusCode = 0;
                             }
                         }
-
-                        StopStreams();
-
-                        if (!_keepAlive)
+                        finally
                         {
-                            // End the connection for non keep alive as data incoming may have been thrown off
-                            return;
+                            _application.DisposeContext(context, _applicationException);
                         }
                     }
 
+                    StopStreams();
+
+                    if (!_keepAlive)
+                    {
+                        // End the connection for non keep alive as data incoming may have been thrown off
+                        return;
+                    }
+
                     // Don't reset frame state if we're exiting the loop. This avoids losing request rejection
                     // information (for 4xx response), and prevents ObjectDisposedException on HTTPS (ODEs
                     // will be thrown if PrepareRequest is not null and references objects disposed on connection

test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ResponseTests.cs

@@ -210,7 +210,7 @@ public Task ResponseStatusCodeSetBeforeHttpContextDisposeRequestAborted()
                     return TaskCache.CompletedTask;
                 },
                 expectedClientStatusCode: null,
-                expectedServerStatusCode: HttpStatusCode.OK);
+                expectedServerStatusCode: 0);
         }
 
         [Fact]
@@ -223,7 +223,7 @@ public Task ResponseStatusCodeSetBeforeHttpContextDisposeRequestAbortedAppExcept
                     throw new Exception();
                 },
                 expectedClientStatusCode: null,
-                expectedServerStatusCode: HttpStatusCode.InternalServerError);
+                expectedServerStatusCode: 0);
         }
 
         [Fact]