Remove invalid Debug.Assert in Http2Connection (#3080)

halter73 · halter73 · commit 2b87e7be8525 · 2018-11-08T15:16:27.000-08:00
The _streams dictionary may not contain the completing stream in
OnStreamCompleted since the IsDraining flag is applied beforehand
which allows it to be removed by the request processing thread.
diff --git a/src/Kestrel.Core/Internal/Http2/Http2Connection.cs b/src/Kestrel.Core/Internal/Http2/Http2Connection.cs
@@ -1062,10 +1062,6 @@ void IHttp2StreamLifetimeHandler.OnStreamCompleted(int streamId)
                         _streams.TryRemove(streamId, out _);
                     }
                 }
-                else
-                {
-                    Debug.Assert(false, "Missing stream");
-                }
 
                 if (_activeStreamCount == 0)
                 {

Original file line number	Diff line number	Diff line change
`@@ -1062,10 +1062,6 @@ void IHttp2StreamLifetimeHandler.OnStreamCompleted(int streamId)`
`1062`	`1062`	`_streams.TryRemove(streamId, out _);`
`1063`	`1063`	`}`
`1064`	`1064`	`}`
`1065`		`- else`
`1066`		`- {`
`1067`		`- Debug.Assert(false, "Missing stream");`
`1068`		`- }`
`1069`	`1065`
`1070`	`1066`	`if (_activeStreamCount == 0)`
`1071`	`1067`	`{`