Removed IsLocal from ConnectionInfo

Author: BrennanConroy

samples/SampleApp/Startup.cs

@@ -55,7 +55,6 @@ public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory, IAp
                 var connectionFeature = context.Connection;
                 Console.WriteLine($"Peer: {connectionFeature.RemoteIpAddress?.ToString()} {connectionFeature.RemotePort}");
                 Console.WriteLine($"Sock: {connectionFeature.LocalIpAddress?.ToString()} {connectionFeature.LocalPort}");
-                Console.WriteLine($"IsLocal: {connectionFeature.IsLocal}");
 
                 context.Response.ContentLength = 11;
                 context.Response.ContentType = "text/plain";

src/Microsoft.AspNet.Server.Kestrel/Http/Frame.FeatureCollection.cs

@@ -272,8 +272,6 @@ bool IHttpUpgradeFeature.IsUpgradableRequest
 
         int IHttpConnectionFeature.LocalPort { get; set; }
 
-        bool IHttpConnectionFeature.IsLocal { get; set; }
-
         object IFeatureCollection.this[Type key]
         {
             get { return FastFeatureGet(key); }

src/Microsoft.AspNet.Server.Kestrel/Http/Frame.cs

@@ -233,15 +233,6 @@ public void Reset()
             httpConnectionFeature.LocalIpAddress = _localEndPoint?.Address;
             httpConnectionFeature.LocalPort = _localEndPoint?.Port ?? 0;
 
-            if (_remoteEndPoint != null && _localEndPoint != null)
-            {
-                httpConnectionFeature.IsLocal = _remoteEndPoint.Address.Equals(_localEndPoint.Address);
-            }
-            else
-            {
-                httpConnectionFeature.IsLocal = false;
-            }
-
             _prepareRequest?.Invoke(this);
 
             _manuallySetRequestAbortToken = null;

test/Microsoft.AspNet.Server.Kestrel.FunctionalTests/RequestTests.cs

@@ -145,8 +145,7 @@ await context.Response.WriteAsync(JsonConvert.SerializeObject(new
                             RemoteIPAddress = connection.RemoteIpAddress?.ToString(),
                             RemotePort = connection.RemotePort,
                             LocalIPAddress = connection.LocalIpAddress?.ToString(),
-                            LocalPort = connection.LocalPort,
-                            IsLocal = connection.IsLocal
+                            LocalPort = connection.LocalPort
                         }));
                     });
                 });
@@ -165,7 +164,6 @@ await context.Response.WriteAsync(JsonConvert.SerializeObject(new
                 var facts = JsonConvert.DeserializeObject<JObject>(connectionFacts);
                 Assert.Equal(expectAddress, facts["RemoteIPAddress"].Value<string>());
                 Assert.NotEmpty(facts["RemotePort"].Value<string>());
-                Assert.True(facts["IsLocal"].Value<bool>());
             }
         }
     }