Gracefully shutdown even when there are open connections

Author: halter73

.gitignore

@@ -7,6 +7,7 @@ _ReSharper.*/
 packages/
 artifacts/
 PublishProfiles/
+.vs/
 *.user
 *.suo
 *.cache

src/Microsoft.AspNet.Server.Kestrel/Infrastructure/KestrelThread.cs

@@ -53,12 +53,16 @@ public void Stop(TimeSpan timeout)
             Post(OnStop, null);
             if (!_thread.Join((int)timeout.TotalMilliseconds))
             {
-                Post(OnStopImmediate, null);
+                Post(OnStopRude, null);
                 if (!_thread.Join((int)timeout.TotalMilliseconds))
                 {
+                    Post(OnStopImmediate, null);
+                    if (!_thread.Join((int)timeout.TotalMilliseconds))
+                    {
 #if DNX451
-                    _thread.Abort();
+                        _thread.Abort();
 #endif
+                    }
                 }
             }
             if (_closeError != null)
@@ -72,6 +76,21 @@ private void OnStop(object obj)
             _post.Unreference();
         }
 
+        private void OnStopRude(object obj)
+        {
+            _engine.Libuv.walk(
+                _loop,
+                (ptr, arg) =>
+                {
+                    var handle = UvMemory.FromIntPtr<UvHandle>(ptr);
+                    if (handle != _post)
+                    {
+                        handle.Dispose();
+                    }
+                },
+                IntPtr.Zero);
+        }
+
         private void OnStopImmediate(object obj)
         {
             _stopImmediate = true;
@@ -133,14 +152,8 @@ private void ThreadStart(object parameter)
                 // run the loop one more time to delete the open handles
                 _post.Reference();
                 _post.DangerousClose();
-                _engine.Libuv.walk(
-                    _loop,
-                    (ptr, arg) =>
-                    {
-                        var handle = UvMemory.FromIntPtr<UvHandle>(ptr);
-                        handle.Dispose();
-                    },
-                    IntPtr.Zero);
+
+                // Ensure the "DangerousClose" operation completes in the event loop.
                 var ran2 = _loop.Run();
 
                 _loop.Dispose();
@@ -203,7 +216,7 @@ private void DoPostCloseHandle()
                 queue = _closeHandleAdding;
                 _closeHandleAdding = _closeHandleRunning;
                 _closeHandleRunning = queue;
-            }            
+            }
             while (queue.Count != 0)
             {
                 var closeHandle = queue.Dequeue();

src/Microsoft.AspNet.Server.Kestrel/Networking/UcAsyncHandle.cs renamed to src/Microsoft.AspNet.Server.Kestrel/Networking/UvAsyncHandle.cs

@@ -32,9 +32,12 @@ protected override bool ReleaseHandle()
                 {
                     _uv.close(memory, _destroyMemory);
                 }
-                else
+                else if (_queueCloseHandle != null)
                 {
-                    _queueCloseHandle(memory2 => _uv.close(memory2, _destroyMemory), memory);
+                    // This can be called from the finalizer.
+                    // Ensure the closure doesn't reference "this".
+                    var uv = _uv;
+                    _queueCloseHandle(memory2 => uv.close(memory2, _destroyMemory), memory);
                 }
             }
             return true;