Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Commit e033a33

Browse files
author
Cesar Blum Silveira
committed
Bind to 127.0.0.1:0 in tests.
1 parent 6da59d5 commit e033a33

File tree

6 files changed

+19
-17
lines changed

6 files changed

+19
-17
lines changed

‎test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ThreadCountTests.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,16 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
1313
{
1414
public class ThreadCountTests
1515
{
16-
public async Task ZeroToTenThreads(int threadCount)
16+
[Theory]
17+
[MemberData(nameof(OneToTen))]
18+
public async Task OneToTenThreads(int threadCount)
1719
{
1820
var hostBuilder = new WebHostBuilder()
1921
.UseKestrel(options =>
2022
{
2123
options.ThreadCount = threadCount;
2224
})
23-
.UseUrls("http://localhost:0/")
25+
.UseUrls("http://127.0.0.1:0/")
2426
.Configure(app =>
2527
{
2628
app.Run(context =>

‎test/Microsoft.AspNetCore.Server.KestrelTests/ConnectionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void DoesNotEndConnectionOnZeroRead()
2727
FrameFactory = connectionContext => new Frame<HttpContext>(
2828
new DummyApplication(httpContext => TaskUtilities.CompletedTask), connectionContext),
2929
Memory = memory,
30-
ServerAddress = ServerAddress.FromUrl($"http://localhost:0"),
30+
ServerAddress = ServerAddress.FromUrl("http://127.0.0.1:0"),
3131
Thread = engine.Threads[0]
3232
};
3333
var socket = new MockSocket(mockLibuv, Thread.CurrentThread.ManagedThreadId, trace);

‎test/Microsoft.AspNetCore.Server.KestrelTests/EngineTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public void ListenerCanCreateAndDispose(TestServiceContext testContext)
8888
testContext.App = App;
8989
var engine = new KestrelEngine(testContext);
9090
engine.Start(1);
91-
var address = ServerAddress.FromUrl($"http://localhost:0/");
91+
var address = ServerAddress.FromUrl("http://127.0.0.1:0/");
9292
var started = engine.CreateServer(address);
9393
started.Dispose();
9494
engine.Dispose();
@@ -101,7 +101,7 @@ public void ConnectionCanReadAndWrite(TestServiceContext testContext)
101101
testContext.App = App;
102102
var engine = new KestrelEngine(testContext);
103103
engine.Start(1);
104-
var address = ServerAddress.FromUrl($"http://localhost:0/");
104+
var address = ServerAddress.FromUrl("http://127.0.0.1:0/");
105105
var started = engine.CreateServer(address);
106106

107107
var socket = TestConnection.CreateConnectedLoopbackSocket(address.Port);

‎test/Microsoft.AspNetCore.Server.KestrelTests/HttpsConnectionFilterTests.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public async Task CanReadAndWriteWithHttpsConnectionFilter()
7575
new NoOpConnectionFilter())
7676
);
7777

78-
using (var server = new TestServer(App, serviceContext, "https://localhost:0/"))
78+
using (var server = new TestServer(App, serviceContext, "https://127.0.0.1:0/"))
7979
{
8080
using (var client = new HttpClient(handler))
8181
{
@@ -122,7 +122,7 @@ public async Task RequireCertificateFailsWhenNoCertificate()
122122
new NoOpConnectionFilter())
123123
);
124124

125-
using (var server = new TestServer(App, serviceContext, "https://localhost:0/"))
125+
using (var server = new TestServer(App, serviceContext, "https://127.0.0.1:0/"))
126126
{
127127
using (var client = new HttpClient(handler))
128128
{
@@ -172,7 +172,7 @@ public async Task AllowCertificateContinuesWhenNoCertificate()
172172
return context.Response.WriteAsync("hello world");
173173
};
174174

175-
using (var server = new TestServer(app, serviceContext, "https://localhost:0/"))
175+
using (var server = new TestServer(app, serviceContext, "https://127.0.0.1:0/"))
176176
{
177177
using (var client = new HttpClient(handler))
178178
{
@@ -222,7 +222,7 @@ public async Task CertificatePassedToHttpContext()
222222
return context.Response.WriteAsync("hello world");
223223
};
224224

225-
using (var server = new TestServer(app, serviceContext, "https://localhost:0/"))
225+
using (var server = new TestServer(app, serviceContext, "https://127.0.0.1:0/"))
226226
{
227227
// SslStream is used to ensure the certificate is actually passed to the server
228228
// HttpClient might not send the certificate because it is invalid or it doesn't match any
@@ -281,7 +281,7 @@ public async Task HttpsSchemePassedToRequestFeature()
281281

282282
RequestDelegate app = context => context.Response.WriteAsync(context.Request.Scheme);
283283

284-
using (var server = new TestServer(app, serviceContext, "https://localhost:0/"))
284+
using (var server = new TestServer(app, serviceContext, "https://127.0.0.1:0/"))
285285
{
286286
using (var client = new HttpClient(handler))
287287
{
@@ -327,7 +327,7 @@ public async Task DoesNotSupportTls10()
327327
return context.Response.WriteAsync("hello world");
328328
};
329329

330-
using (var server = new TestServer(app, serviceContext, "https://localhost:0/"))
330+
using (var server = new TestServer(app, serviceContext, "https://127.0.0.1:0/"))
331331
{
332332
// SslStream is used to ensure the certificate is actually passed to the server
333333
// HttpClient might not send the certificate because it is invalid or it doesn't match any
@@ -384,7 +384,7 @@ public async Task CertificatePassedToHttpContextIsNotDisposed()
384384
return context.Response.WriteAsync("hello world");
385385
};
386386

387-
using (var server = new TestServer(app, serviceContext, "https://localhost:0/"))
387+
using (var server = new TestServer(app, serviceContext, "https://127.0.0.1:0/"))
388388
{
389389
// SslStream is used to ensure the certificate is actually passed to the server
390390
// HttpClient might not send the certificate because it is invalid or it doesn't match any

‎test/Microsoft.AspNetCore.Server.KestrelTests/MultipleLoopTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ public void ServerPipeDispatchConnections()
157157

158158
var serverListenTcp = new UvTcpHandle(_logger);
159159
serverListenTcp.Init(loop, (a, b) => { });
160-
var address = ServerAddress.FromUrl($"http://localhost:0/");
160+
var address = ServerAddress.FromUrl($"http://127.0.0.1:0/");
161161
serverListenTcp.Bind(address);
162162
var port = serverListenTcp.GetSockIPEndPoint().Port;
163163
serverListenTcp.Listen(128, (_1, status, error, _2) =>

‎test/Microsoft.AspNetCore.Server.KestrelTests/NetworkingTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public void SocketCanBeInitAndClose()
6161
loop.Init(_uv);
6262
var tcp = new UvTcpHandle(_logger);
6363
tcp.Init(loop, (a, b) => { });
64-
var address = ServerAddress.FromUrl("http://localhost:0/");
64+
var address = ServerAddress.FromUrl("http://127.0.0.1:0/");
6565
tcp.Bind(address);
6666
tcp.Dispose();
6767
loop.Run();
@@ -76,7 +76,7 @@ public async Task SocketCanListenAndAccept()
7676
loop.Init(_uv);
7777
var tcp = new UvTcpHandle(_logger);
7878
tcp.Init(loop, (a, b) => { });
79-
var address = ServerAddress.FromUrl($"http://localhost:0/");
79+
var address = ServerAddress.FromUrl($"http://127.0.0.1:0/");
8080
tcp.Bind(address);
8181
var port = tcp.GetSockIPEndPoint().Port;
8282
tcp.Listen(10, (stream, status, error, state) =>
@@ -105,7 +105,7 @@ public async Task SocketCanRead()
105105
loop.Init(_uv);
106106
var tcp = new UvTcpHandle(_logger);
107107
tcp.Init(loop, (a, b) => { });
108-
var address = ServerAddress.FromUrl($"http://localhost:0/");
108+
var address = ServerAddress.FromUrl($"http://127.0.0.1:0/");
109109
tcp.Bind(address);
110110
var port = tcp.GetSockIPEndPoint().Port;
111111
tcp.Listen(10, (_, status, error, state) =>
@@ -155,7 +155,7 @@ public async Task SocketCanReadAndWrite()
155155
loop.Init(_uv);
156156
var tcp = new UvTcpHandle(_logger);
157157
tcp.Init(loop, (a, b) => { });
158-
var address = ServerAddress.FromUrl($"http://localhost:0/");
158+
var address = ServerAddress.FromUrl($"http://127.0.0.1:0/");
159159
tcp.Bind(address);
160160
var port = tcp.GetSockIPEndPoint().Port;
161161
tcp.Listen(10, (_, status, error, state) =>

0 commit comments

Comments
 (0)