Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

FrameRequestHeaders:AppendNonPrimaryHeaders uses (and zeros) 888 bytes of stack #1317

Closed
benaadams opened this issue Jan 22, 2017 · 2 comments
Closed

FrameRequestHeaders:AppendNonPrimaryHeaders uses (and zeros) 888 bytes of stack #1317

benaadams opened this issue Jan 22, 2017 · 2 comments

Comments

@benaadams
Copy link
Contributor 

; Assembly listing for method FrameRequestHeaders:AppendNonPrimaryHeaders(long,int,int,ref):this
...
; Lcl frame size = 888

G_M22131_IG01:
       57                   push     rdi
       56                   push     rsi
       4881EC78030000       sub      rsp, 888
       488BF1               mov      rsi, rcx
       488D7C2420           lea      rdi, [rsp+20H]
       B9D6000000           mov      ecx, 214
       33C0                 xor      rax, rax
       F3AB                 rep stosd 
....
@benaadams
Copy link
Contributor Author

Picking this up in #1313 commit e330a9c down to 64 bytes

@benaadams benaadams mentioned this issue Jan 23, 2017
Closed
@muratg muratg closed this as completed Feb 3, 2017
@muratg
Copy link
Contributor

muratg commented Feb 3, 2017

(@benaadams closing these few issues due to the move to pipelines)

@aspnet-hello aspnet-hello mentioned this issue Jan 1, 2018
Closed
@benaadams benaadams mentioned this issue Mar 20, 2019
Closed
@benaadams benaadams mentioned this issue Jan 31, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benaadams @muratg