You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 18, 2018. It is now read-only.
I'm looking at the unicode issue. @davidfowl you seemed to thing the Unicode + WriteAscii method is okay. What was the justification?
Before #1504, we used Encoding.ASCII.GetBytes which does a range change on data and replaces out-of-range characters with '?'. The new implementation doesn't range check.
Comparison:
They are response headers and ValidateHeaderCharacters is run on them when they are added to the collections (so they throw an exception in user code when added if not ascii) so there is no need to check them again on output.
In this PR: #1504
/cc @davidfowl
The text was updated successfully, but these errors were encountered: