IHttpRequestFeature.Scheme not set to HTTPS

[Tratcher]

When using HTTPS/TLS the IHttpRequestFeature is not set accordingly, all requests are reported as http.

[NickCraver]

What's the expectation on reporting in the SSL termination (e.g. reverse proxy) case? For example, will Kestrel eventually be aware of the X-Forwarded-Proto chain or is that entirely up to the application to determine?

[halter73]

@NickCraver I think the expectation is that the developer needs to add our OverrideHeaderMiddleware if they're behind a reverse proxy.

[NickCraver]

@halter73 ah just what I was looking for, thanks! The middleware seems incorrect though. For example, X-Forwarded-Proto is a comma list as well, not a single entry...it's just usually a single entry. The "spec" is multiple though, for example CloudFlare adds one and HAProxy adds one in our case.

[NickCraver]

@halter73 I appreciate the link; I couldn't find that when looking. Issue opened on that repo: aspnet/BasicMiddleware#18

[halter73]

Fixed by #385