Skip to content
This repository was archived by the owner on Nov 1, 2018. It is now read-only.

Commit d208be6

Browse files
committed
Bump test projects up to .NET 4.5.2
- aspnet/Testing#248 - xUnit no longer supports .NET 4.5.1 - build tests for desktop .NET only on Windows
1 parent 73f4b60 commit d208be6

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.Tests.csproj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<Import Project="..\..\build\common.props" />
33
<PropertyGroup>
4-
<TargetFrameworks>net451;netcoreapp1.1</TargetFrameworks>
4+
<TargetFrameworks>net452;netcoreapp1.1</TargetFrameworks>
5+
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp1.1</TargetFrameworks>
56
<RuntimeIdentifier Condition="'$(TargetFramework)' != 'netcoreapp1.1'">win7-x64</RuntimeIdentifier>
67
</PropertyGroup>
78
<ItemGroup>
@@ -12,7 +13,7 @@
1213
<PackageReference Include="xunit" Version="2.2.0-*" />
1314
<PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" />
1415
</ItemGroup>
15-
<ItemGroup Condition="'$(TargetFramework)' == 'net451'">
16+
<ItemGroup Condition="'$(TargetFramework)' == 'net452'">
1617
<PackageReference Include="System.AppContext" Version="4.4.0-*" />
1718
</ItemGroup>
1819
</Project>

test/Microsoft.Data.Sqlite.Tests/NativeLibraryLoaderTest.net451.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) .NET Foundation. All rights reserved.
22
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
33

4-
#if NET451
4+
#if NET452
55
using System;
66
using System.IO;
77
using System.Reflection;

test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace Microsoft.Data.Sqlite
1313
{
1414
public class SqliteConnectionTest
1515
{
16-
#if NET451
16+
#if NET452
1717
private static readonly string BaseDirectory = AppDomain.CurrentDomain.BaseDirectory;
1818
#else
1919
private static readonly string BaseDirectory = AppContext.BaseDirectory;

test/Microsoft.Data.Sqlite.Tests/SqliteDataReaderTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ public void IsClosed_returns_true_when_closed()
634634
connection.Open();
635635

636636
var reader = connection.ExecuteReader("SELECT 1;");
637-
#if NET451
637+
#if NET452
638638
reader.Close();
639639
#else
640640
((IDisposable)reader).Dispose();

0 commit comments

Comments
 (0)