Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Commit 40f72d4

Browse files
author
N. Taylor Mullen
committed
Addressed code review comments.
1 parent 06caaf6 commit 40f72d4

File tree

30 files changed

+6
-150
lines changed

30 files changed

+6
-150
lines changed

‎samples/MvcSandbox/MvcSandbox.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
<PropertyGroup>
66
<TargetFrameworks>net451;netcoreapp1.1</TargetFrameworks>
77
<RuntimeIdentifier Condition=" '$(TargetFramework)' != 'netcoreapp1.1' ">win7-x64</RuntimeIdentifier>
8-
<PreserveCompilationContext>true</PreserveCompilationContext>
9-
<OutputType>Exe</OutputType>
108
</PropertyGroup>
119

1210
<ItemGroup>

‎test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/DefaultAssemblyPartDiscoveryProviderTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,6 @@ public void ReferenceAssemblies_ReturnsLoadableReferenceAssemblies()
214214
"microsoft.aspnetcore.mvc.webapicompatshim",
215215
"microsoft.aspnetcore.mvc.testcommon",
216216
"microsoft.aspnetcore.mvc.core.test",
217-
"microsoft.aspnetcore.mvc.testdiagnosticlistener.sources",
218217
};
219218

220219
var additionalAssemblies = new[]

‎test/Microsoft.AspNetCore.Mvc.Core.Test/Microsoft.AspNetCore.Mvc.Core.Test.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
<PropertyGroup>
55
<TargetFrameworks>netcoreapp1.1;net451</TargetFrameworks>
6-
<PreserveCompilationContext>true</PreserveCompilationContext>
76
</PropertyGroup>
87

98
<ItemGroup>

‎test/Microsoft.AspNetCore.Mvc.Core.Test/xunit.runner.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
{
2+
/* This is a workaround for https://github.com/Microsoft/vstest/issues/196. */
23
"shadowCopy": false
34
}

‎test/Microsoft.AspNetCore.Mvc.FunctionalTests/TagHelpersFromServicesTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public TagHelpersFromServicesTest(MvcTestFixture<ControllersFromServicesWebSite.
1616

1717
public HttpClient Client { get; }
1818

19-
[Fact]
19+
[Fact(Skip = "Workaround for https://github.com/aspnet/Mvc/issues/5768.")]
2020
public async Task TagHelpersWithConstructorInjectionAreCreatedAndActivated()
2121
{
2222
// Arrange

‎test/Microsoft.AspNetCore.Mvc.FunctionalTests/testoutput.txt

Lines changed: 0 additions & 53 deletions
This file was deleted.

‎test/Microsoft.AspNetCore.Mvc.FunctionalTests/testoutput2.txt

Lines changed: 0 additions & 53 deletions
This file was deleted.

‎test/Microsoft.AspNetCore.Mvc.Razor.Test/Microsoft.AspNetCore.Mvc.Razor.Test.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
<PropertyGroup>
66
<TargetFrameworks>netcoreapp1.1;net451</TargetFrameworks>
77
<DefineConstants>$(DefineConstants);SOME_TEST_DEFINE</DefineConstants>
8-
<PreserveCompilationContext>true</PreserveCompilationContext>
98
</PropertyGroup>
109

1110
<ItemGroup>

‎test/Microsoft.AspNetCore.Mvc.Razor.Test/xunit.runner.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
{
2+
/* This is a workaround for https://github.com/Microsoft/vstest/issues/196. */
23
"shadowCopy": false
34
}

‎test/WebSites/ApiExplorerWebSite/ApiExplorerWebSite.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
<PropertyGroup>
66
<TargetFrameworks>net451;netcoreapp1.1</TargetFrameworks>
77
<RuntimeIdentifier Condition=" '$(TargetFramework)' != 'netcoreapp1.1' ">win7-x64</RuntimeIdentifier>
8-
<PreserveCompilationContext>true</PreserveCompilationContext>
9-
<OutputType>Exe</OutputType>
108
</PropertyGroup>
119

1210
<ItemGroup>

‎test/WebSites/ApplicationModelWebSite/ApplicationModelWebSite.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
<PropertyGroup>
66
<TargetFrameworks>net451;netcoreapp1.1</TargetFrameworks>
77
<RuntimeIdentifier Condition=" '$(TargetFramework)' != 'netcoreapp1.1' ">win7-x64</RuntimeIdentifier>
8-
<PreserveCompilationContext>true</PreserveCompilationContext>
9-
<OutputType>Exe</OutputType>
108
</PropertyGroup>
119

1210
<ItemGroup>

0 commit comments

Comments
 (0)