Changes per discussion

Author: pranavkm

src/Microsoft.AspNetCore.Mvc.ApiExplorer/ProblemDetailsApiDescriptionProvider.cs

@@ -47,6 +47,8 @@ public void OnProvidersExecuting(ApiDescriptionProviderContext context)
                     }
                 }
 
+                // We don't have a good way to signal a "default" response type. We'll use 0 to indicate this until we come up
+                // with something better.
                 apiDescription.SupportedResponseTypes.Add(CreateProblemResponse(statusCode: 0));
             }
         }

src/Microsoft.AspNetCore.Mvc.Core/ControllerBase.cs

@@ -1503,7 +1503,7 @@ public virtual BadRequestObjectResult BadRequest(ModelStateDictionary modelState
         /// </summary>
         /// <returns>The created <see cref="BadRequestObjectResult"/> for the response.</returns>
         [NonAction]
-        public virtual BadRequestObjectResult ValidationProblem(ValidationProblemDetails descriptor)
+        public virtual ActionResult ValidationProblem(ValidationProblemDetails descriptor)
         {
             if (descriptor == null)
             {
@@ -1518,7 +1518,7 @@ public virtual BadRequestObjectResult ValidationProblem(ValidationProblemDetails
         /// </summary>
         /// <returns>The created <see cref="BadRequestObjectResult"/> for the response.</returns>
         [NonAction]
-        public virtual BadRequestObjectResult ValidationProblem(ModelStateDictionary modelStateDictionary)
+        public virtual ActionResult ValidationProblem(ModelStateDictionary modelStateDictionary)
         {
             if (modelStateDictionary == null)
             {
@@ -1535,7 +1535,7 @@ public virtual BadRequestObjectResult ValidationProblem(ModelStateDictionary mod
         /// </summary>
         /// <returns>The created <see cref="BadRequestObjectResult"/> for the response.</returns>
         [NonAction]
-        public virtual BadRequestObjectResult ValidationProblem()
+        public virtual ActionResult ValidationProblem()
         {
             var validationProblem = new ValidationProblemDetails(ModelState);
             return new BadRequestObjectResult(validationProblem);

src/Microsoft.AspNetCore.Mvc.Core/DependencyInjection/MvcCoreServiceCollectionExtensions.cs

@@ -204,9 +204,6 @@ internal static void AddMvcCoreServices(IServiceCollection services)
             services.TryAddTransient<RequestSizeLimitFilter>();
             services.TryAddTransient<DisableRequestSizeLimitFilter>();
 
-            // Action Filters
-            services.TryAddTransient<ProblemDetailsFilter>();
-
             // Error description
             services.TryAddSingleton<IErrorDescriptionFactory, DefaultErrorDescriptorFactory>();
 

src/Microsoft.AspNetCore.Mvc.Core/Infrastructure/IErrorDescriptorProvider.cs

@@ -9,7 +9,5 @@ public interface IErrorDescriptorProvider
         int Order { get; }
 
         void OnProvidersExecuting(ErrorDescriptionContext context);
-
-        void OnProvidersExecuted(ErrorDescriptionContext context);
     }
 }

src/Microsoft.AspNetCore.Mvc.Core/Internal/DefaultErrorDescriptorFactory.cs

@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.AspNetCore.Mvc.Abstractions;
@@ -14,11 +15,26 @@ public class DefaultErrorDescriptorFactory : IErrorDescriptionFactory
 
         public DefaultErrorDescriptorFactory(IEnumerable<IErrorDescriptorProvider> providers)
         {
+            if (providers == null)
+            {
+                throw new ArgumentNullException(nameof(providers));
+            }
+
             _providers = providers.OrderBy(p => p.Order).ToArray();
         }
 
         public object CreateErrorDescription(ActionDescriptor actionDescriptor, object result)
         {
+            if (actionDescriptor == null)
+            {
+                throw new ArgumentNullException(nameof(actionDescriptor));
+            }
+
+            if (result == null)
+            {
+                throw new ArgumentNullException(nameof(result));
+            }
+
             var context = new ErrorDescriptionContext(actionDescriptor)
             {
                 Result = result,
@@ -29,11 +45,6 @@ public object CreateErrorDescription(ActionDescriptor actionDescriptor, object r
                 _providers[i].OnProvidersExecuting(context);
             }
 
-            for (var i = _providers.Length - 1; i >= 0; i--)
-            {
-                _providers[i].OnProvidersExecuted(context);
-            }
-
             return context.Result ?? result;
         }
     }

src/Microsoft.AspNetCore.Mvc.Core/Internal/ProblemDetailsFilter.cs

@@ -3,40 +3,14 @@
 
 using System;
 using Microsoft.AspNetCore.Mvc.Filters;
-using Microsoft.AspNetCore.Mvc.Internal;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.AspNetCore.Mvc
 {
     /// <summary>
-    /// Adds an <see cref="IFilterMetadata"/> that enhances some basic 4xx client error responses.
-    /// <para>
-    /// The <see cref="ProblemDetailsAttribute"/> adds an <see cref="IActionFilter"/> that adds details to the HTTP
-    /// response, when the action signature matches certain patterns. By default, a <see cref="ProblemDetails"/>
-    /// is returned in the response body. This can be further configured by registering instances of 
-    /// <see cref="Infrastructure.IErrorDescriptorProvider"/> in the service container.
-    /// </para>
-    /// Patterns matched by the filter include:
-    /// <list>
-    /// <item>400 <see cref="StatusCodeResult"/> on any action which participates in model binding.</item>
-    /// <item>404 <see cref="StatusCodeResult"/> on any action with an <c>id</c> parameter.</item>
-    /// </list>
+    /// Adds an <see cref="IFilterMetadata"/> that indicates to the framework that the current action conforms to well-known API behavior.
     /// </summary>
     [AttributeUsage(AttributeTargets.Method | AttributeTargets.Class, AllowMultiple = false, Inherited = true)]
-    public class ProblemDetailsAttribute : Attribute, IFilterFactory
+    public class ProblemDetailsAttribute : Attribute, IFilterMetadata
     {
-        /// <inheritdoc />
-        public bool IsReusable => true;
-
-        /// <inheritdoc />
-        public IFilterMetadata CreateInstance(IServiceProvider serviceProvider)
-        {
-            if (serviceProvider == null)
-            {
-                throw new ArgumentNullException(nameof(serviceProvider));
-            }
-
-            return serviceProvider.GetRequiredService<ProblemDetailsFilter>();
-        }
     }
 }

src/Microsoft.AspNetCore.Mvc.Core/ProblemDetailsAttribute.cs

@@ -415,13 +415,4 @@
   <data name="ValidationProblemDescription_Title" xml:space="preserve">
     <value>One or more validation errors occured.</value>
   </data>
-  <data name="ProblemDetails_400_Title" xml:space="preserve">
-    <value>400 Bad Request</value>
-  </data>
-  <data name="ProblemDetails_404_Title" xml:space="preserve">
-    <value>Resource with the specified id could not be found.</value>
-  </data>
-  <data name="ProblemDetails_415_Title" xml:space="preserve">
-    <value>The request entity is in a format that is not supported by the requested resource.</value>
-  </data>
 </root>