React to authentication API changes.

Author: Tratcher

src/Microsoft.AspNet.Mvc.Core/ActionResults/ChallengeResult.cs

@@ -46,17 +46,17 @@ public ChallengeResult(IList<string> authenticationSchemes, AuthenticationProper
 
         public override void ExecuteResult([NotNull] ActionContext context)
         {
-            var response = context.HttpContext.Response;
+            var auth = context.HttpContext.Authentication;
             if (AuthenticationSchemes.Count > 0)
             {
                 foreach (var scheme in AuthenticationSchemes)
                 {
-                    response.Challenge(Properties, scheme);
+                    auth.Challenge(scheme, Properties);
                 }
             }
             else
             {
-                response.Challenge(Properties);
+                auth.Challenge(Properties);
             }
         }
     }

src/Microsoft.AspNet.Mvc.Core/Filters/AuthorizeFilter.cs

@@ -38,7 +38,7 @@ public virtual async Task OnAuthorizationAsync([NotNull] AuthorizationContext co
                 var newPrincipal = new ClaimsPrincipal();
                 foreach (var scheme in Policy.ActiveAuthenticationSchemes)
                 {
-                    var result = (await context.HttpContext.AuthenticateAsync(scheme))?.Principal;
+                    var result = (await context.HttpContext.Authentication.AuthenticateAsync(scheme))?.Principal;
                     if (result != null)
                     {
                         newPrincipal.AddIdentities(result.Identities);

test/Microsoft.AspNet.Mvc.Core.Test/ActionResults/ChallengeResultTest.cs

@@ -18,8 +18,8 @@ public void ChallengeResult_Execute()
             // Arrange
             var result = new ChallengeResult("", null);
             var httpContext = new Mock<HttpContext>();
-            var httpResponse = new Mock<HttpResponse>();
-            httpContext.Setup(o => o.Response).Returns(httpResponse.Object);
+            var auth = new Mock<AuthenticationManager>();
+            httpContext.Setup(o => o.Authentication).Returns(auth.Object);
 
             var routeData = new RouteData();
             routeData.Routers.Add(Mock.Of<IRouter>());
@@ -32,7 +32,7 @@ public void ChallengeResult_Execute()
             result.ExecuteResult(actionContext);
 
             // Assert
-            httpResponse.Verify(c => c.Challenge(null, ""), Times.Exactly(1));
+            auth.Verify(c => c.Challenge("", null), Times.Exactly(1));
         }
 
         [Fact]
@@ -41,8 +41,8 @@ public void ChallengeResult_ExecuteNoSchemes()
             // Arrange
             var result = new ChallengeResult(new string[] { }, null);
             var httpContext = new Mock<HttpContext>();
-            var httpResponse = new Mock<HttpResponse>();
-            httpContext.Setup(o => o.Response).Returns(httpResponse.Object);
+            var auth = new Mock<AuthenticationManager>();
+            httpContext.Setup(o => o.Authentication).Returns(auth.Object);
 
             var routeData = new RouteData();
             routeData.Routers.Add(Mock.Of<IRouter>());
@@ -55,7 +55,7 @@ public void ChallengeResult_ExecuteNoSchemes()
             result.ExecuteResult(actionContext);
 
             // Assert
-            httpResponse.Verify(c => c.Challenge((AuthenticationProperties)null), Times.Exactly(1));
+            auth.Verify(c => c.Challenge((AuthenticationProperties)null), Times.Exactly(1));
         }
     }
 }

test/Microsoft.AspNet.Mvc.Core.Test/Filters/AuthorizeFilterTest.cs

@@ -352,14 +352,16 @@ private AuthorizationContext GetAuthorizationContext(Action<ServiceCollection> r
 
             // HttpContext
             var httpContext = new Mock<HttpContext>();
+            var auth = new Mock<AuthenticationManager>();
+            httpContext.Setup(o => o.Authentication).Returns(auth.Object);
             httpContext.SetupProperty(c => c.User);
             if (!anonymous)
             {
                 httpContext.Object.User = validUser;
             }
             httpContext.SetupGet(c => c.RequestServices).Returns(serviceProvider);
-            httpContext.Setup(c => c.AuthenticateAsync("Bearer")).ReturnsAsync(new AuthenticationResult(bearerPrincipal, new AuthenticationProperties(), new AuthenticationDescription()));
-            httpContext.Setup(c => c.AuthenticateAsync("Basic")).ReturnsAsync(new AuthenticationResult(basicPrincipal, new AuthenticationProperties(), new AuthenticationDescription()));
+            auth.Setup(c => c.AuthenticateAsync("Bearer")).ReturnsAsync(new AuthenticationResult(bearerPrincipal, new AuthenticationProperties(), new AuthenticationDescription()));
+            auth.Setup(c => c.AuthenticateAsync("Basic")).ReturnsAsync(new AuthenticationResult(basicPrincipal, new AuthenticationProperties(), new AuthenticationDescription()));
 
             // AuthorizationContext
             var actionContext = new ActionContext(