Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Commit febd5c4

Browse files
committed
Address InputTagHelper PR comments, add tests, and fix problems found
- remove `InputTagHelper.DefaultInputTypes` - `InputTagHelper.Type` -> `InputTagHelper.InputTypeName` - `GetFormat()` uses a `Dictionary` for data / time formats - also fix "decimal" handling - move strings to `Resources` nits: - address TODO items to use `TagHelperOutputExtensions` - pass `ModelMetadata` around
1 parent add57da commit febd5c4

File tree

6 files changed

+384
-130
lines changed

6 files changed

+384
-130
lines changed

samples/TagHelperSample.Web/Views/Home/Create.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
<div class="col-md-10">
3838
@* will automatically infer type="date" (reused HTML attribute) and format="{0:d}" (optional bound attribute) *@
3939
<input for="DateOfBirth" />
40-
<span validation-for="DateOfBirth">How old are you?</span>
40+
<span validation-for="DateOfBirth">When were you born?</span>
4141
</div>
4242
</div>
4343
<div class="form-group">

samples/TagHelperSample.Web/Views/Home/Edit.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<label for="DateOfBirth" class="control-label col-md-2" />
2121
<div class="col-md-10">
2222
<input type="date" for="DateOfBirth" format="{0:d}" />
23-
<span validation-for="DateOfBirth">How old are you?</span>
23+
<span validation-for="DateOfBirth" />
2424
</div>
2525
</div>
2626
<div class="form-group">

0 commit comments

Comments
 (0)