Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Implement fix for RSuter/NSwag#1626 #8425

Closed
dougbu opened this issue Sep 7, 2018 · 7 comments
Closed

Implement fix for RSuter/NSwag#1626 #8425

dougbu opened this issue Sep 7, 2018 · 7 comments
Assignees
Labels
3 - Done cost: S Will take up to 2 days to complete enhancement feature-code-generation PRI: 0 - Critical Blocks a critical product path. Must be handled immediately
Milestone

Comments

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2018

Is this a Bug or Feature request?

Enhancement that's part of #7947

Description of the problem

RicoSuter/NSwag#313 covers the IDocumentProvider service that we've chosen to initiate ourselves. This issue tracks submitting our proposed additions to the NSwag.AspNetCore and (at least) NSwag.SwaggerGeneration.AspNetCore packages and getting that code into master.

(Note RicoSuter/NSwag#313 is a rather old issue and not specifically about IDocumentProvider. Will either flesh out that issue with IDocumentProvider information or create a separate issue tracking this work in the RSuter/NSwag repo.)

Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All

See the features/client.code.generation branch branch. That work is intended for the 2.2 Preview 3 milestone.

@dougbu dougbu added enhancement 1 - Ready cost: S Will take up to 2 days to complete labels Sep 7, 2018
@dougbu dougbu added this to the 2.2.0-preview3 milestone Sep 7, 2018
@dougbu dougbu self-assigned this Sep 7, 2018
@dougbu
Copy link
Contributor Author

dougbu commented Sep 7, 2018

(Am not 100% confident in my cost estimate because I haven't dived deep enough into the NSwag code that is required.)

@RicoSuter
Copy link

I think RicoSuter/NSwag#313 does not really cover this issue - I think #313 wants to expose an HTTP endpoint to automatically generate C#/TypeScript for "download"... i.e. a web service - not a DI service. Maybe we should create a new issue for the IDocumentProvider service interface...

@mkArtakMSFT mkArtakMSFT added the PRI: 0 - Critical Blocks a critical product path. Must be handled immediately label Sep 21, 2018
@dougbu dougbu changed the title Implement fix for RSuter/NSwag#313 Implement fix for RSuter/NSwag#1626 Sep 21, 2018
@dougbu
Copy link
Contributor Author

dougbu commented Sep 21, 2018

@RSuter I filed RicoSuter/NSwag#1626 and renamed this issue. Is the new issue closer to the mark? Any suggestions?

@RicoSuter
Copy link

RicoSuter commented Oct 1, 2018

@dougbu looks good to me, i’ve added some comments...

@dougbu
Copy link
Contributor Author

dougbu commented Oct 10, 2018

See RicoSuter/NSwag#1658

@mkArtakMSFT mkArtakMSFT modified the milestones: 2.2.0-preview3, 2.2.0 Oct 15, 2018
@mkArtakMSFT mkArtakMSFT modified the milestones: 2.2.0, ClientCodeGen Oct 23, 2018
@dougbu
Copy link
Contributor Author

dougbu commented Oct 26, 2018

With much thanks to @RSuter, this work is done.

@dougbu
Copy link
Contributor Author

dougbu commented Oct 31, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 - Done cost: S Will take up to 2 days to complete enhancement feature-code-generation PRI: 0 - Critical Blocks a critical product path. Must be handled immediately
Projects
None yet
Development

No branches or pull requests

3 participants