This repository was archived by the owner on Dec 14, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Implement fix for RSuter/NSwag#1626 #8425
Labels
3 - Done
cost: S
Will take up to 2 days to complete
enhancement
feature-code-generation
PRI: 0 - Critical
Blocks a critical product path. Must be handled immediately
Milestone
Comments
(Am not 100% confident in my cost estimate because I haven't dived deep enough into the NSwag code that is required.) |
I think RicoSuter/NSwag#313 does not really cover this issue - I think #313 wants to expose an HTTP endpoint to automatically generate C#/TypeScript for "download"... i.e. a web service - not a DI service. Maybe we should create a new issue for the IDocumentProvider service interface... |
@RSuter I filed RicoSuter/NSwag#1626 and renamed this issue. Is the new issue closer to the mark? Any suggestions? |
@dougbu looks good to me, i’ve added some comments... |
With much thanks to @RSuter, this work is done. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3 - Done
cost: S
Will take up to 2 days to complete
enhancement
feature-code-generation
PRI: 0 - Critical
Blocks a critical product path. Must be handled immediately
Is this a Bug or Feature request?
Enhancement that's part of #7947
Description of the problem
RicoSuter/NSwag#313 covers the
IDocumentProvider
service that we've chosen to initiate ourselves. This issue tracks submitting our proposed additions to the NSwag.AspNetCore and (at least) NSwag.SwaggerGeneration.AspNetCore packages and getting that code intomaster
.(Note RicoSuter/NSwag#313 is a rather old issue and not specifically about
IDocumentProvider
. Will either flesh out that issue withIDocumentProvider
information or create a separate issue tracking this work in the RSuter/NSwag repo.)Version of
Microsoft.AspNetCore.Mvc
orMicrosoft.AspNetCore.App
orMicrosoft.AspNetCore.All
See the features/client.code.generation branch branch. That work is intended for the 2.2 Preview 3 milestone.
The text was updated successfully, but these errors were encountered: