Skip to content

Transform @model DirectiveIntermediateNode into a custom directive node type. #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NTaylorMullen opened this issue Aug 14, 2017 · 0 comments
Closed

Transform @model DirectiveIntermediateNode into a custom directive node type. #5025

NTaylorMullen opened this issue Aug 14, 2017 · 0 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-razor-pages task
Milestone
Backlog

Comments

@NTaylorMullen
Copy link

Today our GetModel resolution code assumes that the DirectiveIntermediateNode will be in the document. This isn't a safe assumption since we have a directive removal pass that nukes the existence of that node.

Today this works but it's very fragile.
@aspnet-hello aspnet-hello transferred this issue from aspnet/Razor Dec 14, 2018
@aspnet-hello aspnet-hello added this to the Backlog milestone Dec 14, 2018
@aspnet-hello aspnet-hello added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-razor-pages task labels Dec 14, 2018
@pranavkm pranavkm added the c label Aug 21, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-razor-pages task
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@pranavkm @NTaylorMullen @mkArtakMSFT @aspnet-hello