Feedback

Author: JunTaoLuo

src/Microsoft.AspNetCore.ResponseCaching/ResponseCachingMiddleware.cs

@@ -322,31 +322,23 @@ internal void FinalizeCacheHeaders(ResponseCachingContext context)
         {
             if (OnFinalizeCacheHeaders(context))
             {
-                try
-                {
-                    _cache.Set(
-                        context.BaseKey,
-                        context.CachedVaryByRules,
-                        context.CachedResponseValidFor,
-                        EstimateCachedVaryByRulesySize(context.CachedVaryByRules));
-                }
-                catch (OverflowException) { }
+                _cache.Set(
+                    context.BaseKey,
+                    context.CachedVaryByRules,
+                    context.CachedResponseValidFor,
+                    EstimateCachedVaryByRulesySize(context.CachedVaryByRules));
             }
         }
 
         internal Task FinalizeCacheHeadersAsync(ResponseCachingContext context)
         {
             if (OnFinalizeCacheHeaders(context))
             {
-                try
-                {
-                    return _cache.SetAsync(
-                        context.BaseKey,
-                        context.CachedVaryByRules,
-                        context.CachedResponseValidFor,
-                        EstimateCachedVaryByRulesySize(context.CachedVaryByRules));
-                }
-                catch (OverflowException) { }
+                return _cache.SetAsync(
+                    context.BaseKey,
+                    context.CachedVaryByRules,
+                    context.CachedResponseValidFor,
+                    EstimateCachedVaryByRulesySize(context.CachedVaryByRules));
             }
             return Task.CompletedTask;
         }
@@ -369,15 +361,11 @@ internal async Task FinalizeCacheBodyAsync(ResponseCachingContext context)
                     context.CachedResponse.Body = bufferStream;
                     _logger.LogResponseCached();
 
-                    try
-                    {
-                        await _cache.SetAsync(
-                            context.StorageVaryKey ?? context.BaseKey,
-                            context.CachedResponse,
-                            context.CachedResponseValidFor,
-                            EstimateCachedResponseSize(context.CachedResponse));
-                    }
-                    catch (OverflowException) { }
+                    await _cache.SetAsync(
+                        context.StorageVaryKey ?? context.BaseKey,
+                        context.CachedResponse,
+                        context.CachedResponseValidFor,
+                        EstimateCachedResponseSize(context.CachedResponse));
                 }
                 else
                 {
@@ -569,7 +557,7 @@ internal static long EstimateCachedResponseSize(CachedResponse cachedResponse)
                 // Body
                 if (cachedResponse.Body != null)
                 {
-                    size += cachedResponse.Body.Length * sizeof(char);
+                    size += cachedResponse.Body.Length;
                 }
 
                 return size;