add some logging maybe?

Author: analogrelay

src/Microsoft.AspNetCore.SignalR.Client.Core/HubConnection.cs

@@ -45,6 +45,10 @@ public class HubConnection
 
         public Task Closed { get; }
 
+        /// <summary>
+        /// Gets or sets the server timeout interval for the connection. Changes to this value
+        /// are ignored after <see cref="StartAsync"/> is called.
+        /// </summary>
         public TimeSpan ServerTimeout { get; set; } = DefaultServerTimeout;
 
         public HubConnection(IConnection connection, IHubProtocol protocol, ILoggerFactory loggerFactory)
@@ -66,12 +70,14 @@ public HubConnection(IConnection connection, IHubProtocol protocol, ILoggerFacto
             _logger = _loggerFactory.CreateLogger<HubConnection>();
             _connection.OnReceived((data, state) => ((HubConnection)state).OnDataReceivedAsync(data), this);
             _needKeepAlive = _connection.Features.Get<IConnectionInherentKeepAliveFeature>() == null;
-            _timeoutTimer = new Timer(state => ((HubConnection)state).TimeoutElapsed(), this, -1, -1);
             Closed = _connection.Closed.ContinueWith(task =>
             {
                 Shutdown(task.Exception);
                 return task;
             }).Unwrap();
+
+            // Create the timer for timeout, but disabled by default (we enable it when started).
+            _timeoutTimer = new Timer(state => ((HubConnection)state).TimeoutElapsed(), this, Timeout.Infinite, Timeout.Infinite);
         }
 
         public async Task StartAsync()
@@ -95,6 +101,7 @@ private void ResetTimeoutTimer()
         {
             if (_needKeepAlive)
             {
+                _logger.ResettingKeepAliveTimer();
                 _timeoutTimer.Change(ServerTimeout, Timeout.InfiniteTimeSpan);
             }
         }

src/Microsoft.AspNetCore.SignalR.Client.Core/Internal/SignalRClientLoggerExtensions.cs

@@ -85,6 +85,9 @@ internal static class SignalRClientLoggerExtensions
         private static readonly Action<ILogger, string, string, string, int, Exception> _preparingStreamingInvocation =
             LoggerMessage.Define<string, string, string, int>(LogLevel.Trace, new EventId(24, nameof(PreparingStreamingInvocation)), "Preparing streaming invocation '{invocationId}' of '{target}', with return type '{returnType}' and {argumentCount} argument(s).");
 
+        private static readonly Action<ILogger, Exception> _resettingKeepAliveTimer =
+            LoggerMessage.Define(LogLevel.Trace, new EventId(25, nameof(ResettingKeepAliveTimer)), "Resetting keep-alive timer, received a message from the server");
+
         // Category: Streaming and NonStreaming
         private static readonly Action<ILogger, string, Exception> _invocationCreated =
             LoggerMessage.Define<string>(LogLevel.Trace, new EventId(0, nameof(InvocationCreated)), "Invocation {invocationId} created.");
@@ -282,7 +285,12 @@ public static void StreamItemOnNonStreamInvocation(this ILogger logger, string i
 
         public static void ErrorInvokingClientSideMethod(this ILogger logger, string methodName, Exception exception)
         {
-             _errorInvokingClientSideMethod(logger, methodName, exception);
+            _errorInvokingClientSideMethod(logger, methodName, exception);
+        }
+
+        public static void ResettingKeepAliveTimer(this ILogger logger)
+        {
+            _resettingKeepAliveTimer(logger);
         }
     }
 }