feedback and fix build error

Author: analogrelay

src/Microsoft.AspNetCore.SignalR.Client.Core/Internal/SignalRClientLoggerExtensions.cs

@@ -290,7 +290,7 @@ public static void ErrorInvokingClientSideMethod(this ILogger logger, string met
 
         public static void ResettingKeepAliveTimer(this ILogger logger)
         {
-            _resettingKeepAliveTimer(logger);
+            _resettingKeepAliveTimer(logger, null);
         }
     }
 }

src/Microsoft.AspNetCore.SignalR.Common/Internal/Protocol/HubProtocolConstants.cs

@@ -1,6 +1,6 @@
 namespace Microsoft.AspNetCore.SignalR.Internal.Protocol
 {
-    internal static class HubProtocolConstants
+    public static class HubProtocolConstants
     {
         public const int InvocationMessageType = 1;
         public const int StreamItemMessageType = 2;

test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs

@@ -679,12 +679,6 @@ public async Task KeepAliveBehaviorIsCorrect(TransportType transportType)
                     await hubConnection.InvokeAsync("Echo", "foo");
                     await Task.Delay(50);
                     Assert.False(hubConnection.Closed.IsCompleted);
-
-                    if (transportType != TransportType.LongPolling)
-                    {
-                        var ex = await Assert.ThrowsAsync<TimeoutException>(async () => await hubConnection.Closed.OrTimeout(milliseconds: 500));
-                        Assert.Equal("Server timeout elapsed without receiving a message from the server.", ex.Message);
-                    }
                 }
                 catch (Exception ex)
                 {
@@ -693,13 +687,15 @@ public async Task KeepAliveBehaviorIsCorrect(TransportType transportType)
                 }
                 finally
                 {
-                    try
+                    if (transportType == TransportType.LongPolling)
                     {
                         await hubConnection.DisposeAsync().OrTimeout();
                     }
-                    catch (TimeoutException) when (transportType != TransportType.LongPolling)
+                    else
                     {
-                        // Already observed this exception!
+                        // We should have timed out the other transports.
+                        var ex = await Assert.ThrowsAsync<TimeoutException>(async () => await hubConnection.Closed.OrTimeout(milliseconds: 500));
+                        Assert.Equal("Server timeout elapsed without receiving a message from the server.", ex.Message);
                     }
                 }
             }

test/Microsoft.AspNetCore.SignalR.Client.Tests/HubConnectionTests.cs

@@ -212,11 +212,11 @@ public async Task ConnectionNotTerminatedIfServerKeepsSending()
 
             try
             {
-                await connection.ReceiveJsonMessage(new { type = 6 });
+                await connection.ReceiveJsonMessage(new { type = HubProtocolConstants.PingMessageType });
                 await Task.Delay(50);
-                await connection.ReceiveJsonMessage(new { type = 6 });
+                await connection.ReceiveJsonMessage(new { type = HubProtocolConstants.PingMessageType });
                 await Task.Delay(50);
-                await connection.ReceiveJsonMessage(new { type = 6 });
+                await connection.ReceiveJsonMessage(new { type = HubProtocolConstants.PingMessageType });
                 await Task.Delay(50);
 
                 Assert.False(hubConnection.Closed.IsCompleted);

test/Microsoft.AspNetCore.SignalR.Client.Tests/LongPollingTransportTests.cs

@@ -9,13 +9,13 @@
 using System.Threading;
 using System.Threading.Channels;
 using System.Threading.Tasks;
+using Microsoft.AspNetCore.SignalR.Client.Tests;
 using Microsoft.AspNetCore.Sockets;
 using Microsoft.AspNetCore.Sockets.Client;
 using Microsoft.AspNetCore.Sockets.Internal;
 using Moq;
 using Moq.Protected;
 using Xunit;
-using Microsoft.AspNetCore.SignalR.Client.Tests;
 
 namespace Microsoft.AspNetCore.Client.Tests
 {

test/Microsoft.AspNetCore.SignalR.Tests/WebSocketsTransportTests.cs

@@ -9,9 +9,9 @@
 using Microsoft.AspNetCore.Sockets.Internal;
 using Microsoft.AspNetCore.Testing.xunit;
 using Microsoft.Extensions.Logging.Testing;
+using Moq;
 using Xunit;
 using Xunit.Abstractions;
-using Moq;
 
 namespace Microsoft.AspNetCore.SignalR.Tests
 {