Skip to content
This repository was archived by the owner on Apr 11, 2020. It is now read-only.

Unable to Change Resx Resources Access Modifier #339

Closed
RehanSaeed opened this issue Dec 17, 2015 · 11 comments
Closed

Unable to Change Resx Resources Access Modifier #339

RehanSaeed opened this issue Dec 17, 2015 · 11 comments

Comments

@RehanSaeed
Copy link

Create a new Resource.resx and you will see that the access modifier combo box is disabled, thus not allowing you to change it from internal to public.

@sayedihashimi
Copy link
Contributor

TFS: 174065
I've added this to our internal TFS, we will reply back here soon.

@senritsu
Copy link

Are there any updates on this issue yet?

@ghost
Copy link

ghost commented Jan 28, 2016

I've struck this issue as well, and haven't found any solution online yet, at least nothing recent and related to either VS 2015 or the new ASP NET Core stuff. Is this actually an issue there, then?

@sayedihashimi
Copy link
Contributor

Hi everyone, I'm really sorry you're running into this. It was a mistake on our part. In our next release we are going to change it to generate public classes by default. In a release after that we'll enable changing the value in the UI.

The only workaround here is to generate the file and then change internal to public. If you re-generate the .resx file you'll need to update the class again :(.

@michael-x
Copy link

Hi @sayedihashimi, is the final solution going to be that one can choose between public and internal or is it going to let us choose a custom tool. We've used a custom tool to generate methods with appropriate parameters instead of properties, which makes usage of resource strings type-safe.

@michael-x
Copy link

Hi @sayedihashimi, just stumbled across dotnet/aspnetcore#272, so disregard my comment, please.

@sayedihashimi
Copy link
Contributor

See #394.

For this particular issue we already have a fix ready that changes the default to public. Later we will come with a better story.

@weslyisaacd
Copy link

weslyisaacd commented May 9, 2016

When can we expect resource file with access modifier selector? do you have any timeline?

@Verdant90
Copy link

Any news on the subject?

@sayedihashimi
Copy link
Contributor

Sorry for the delay here. I was hoping that this would come "for free" when we moved to the roslyn project system, but it looks like there may be some pending work here.

I've created a new bug to track the pending work at dotnet/project-system#1097. Let's use that for any communication going forward. I'll close this one.

@sayedihashimi
Copy link
Contributor

FYI this has been fixed I just verified on my other machine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants