Skip to content
This repository was archived by the owner on Oct 18, 2018. It is now read-only.

Provide way to disable trimming against shared framework for source-build installations #1125

Closed
2 tasks done
natemcmaster opened this issue Apr 27, 2018 · 1 comment
Closed
2 tasks done
Assignees
Labels
3 - Done Servicing-approved Shiproom has approved the issue
Milestone

Comments

@natemcmaster
Copy link
Contributor

natemcmaster commented Apr 27, 2018

To address dotnet/source-build#456, we want to make it easier to opt-out of the aspnet shared framework.

Changes to make in our code

  • Make the override for MicrosoftNETPlatformLibrary in our .App and .All packages conditional on a property.
  • Set this property in source-build installations of the SDK

Implications

  • Default templates will build and run on source-build installations without requiring changes to the file or special properties passed as command line flags.
  • Apps will run from the NuGet cache, not the optimized shared framework. This means slower startup and larger application size.
  • Users who publish an app with a non-source-build SDK (e.g. publish on Windows) and then try to run on a source-build-only server will be missing the shared framework. This situation is similar to several other scenarios where servers may not be configured with the aspnet shared framework, so we believe this will be address with documentation on how to configure a server with the aspnet shared runtime.

cc @omajid @tmds @muratg

@natemcmaster natemcmaster added this to the 2.1.0 milestone Apr 27, 2018
@natemcmaster natemcmaster self-assigned this Apr 27, 2018
@natemcmaster natemcmaster added the Servicing-consider Shiproom approval is required for the issue label Apr 30, 2018
@natemcmaster natemcmaster added 2 - Working Servicing-approved Shiproom has approved the issue 3 - Done and removed 1 - Ready Servicing-consider Shiproom approval is required for the issue 2 - Working labels May 1, 2018
@natemcmaster
Copy link
Contributor Author

Done. Changes are in to both dotnet/CLI and aspnetcore.

#1130
dotnet/cli#9178

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 - Done Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

No branches or pull requests

1 participant