Skip to content
This repository was archived by the owner on Oct 18, 2018. It is now read-only.

Commit ac0ee35

Browse files
authored
Change AutobahnTester to use dynamic ports with Kestrel (#238)
- Depends on aspnet/Hosting#1388 - Addresses dotnet/aspnetcore#3062
1 parent 4db62c5 commit ac0ee35

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

build/dependencies.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<MicrosoftAspNetCoreHttpExtensionsPackageVersion>2.1.0-preview3-32233</MicrosoftAspNetCoreHttpExtensionsPackageVersion>
1010
<MicrosoftAspNetCoreServerHttpSysPackageVersion>2.1.0-preview3-32233</MicrosoftAspNetCoreServerHttpSysPackageVersion>
1111
<MicrosoftAspNetCoreServerIISIntegrationPackageVersion>2.1.0-preview3-32233</MicrosoftAspNetCoreServerIISIntegrationPackageVersion>
12-
<MicrosoftAspNetCoreServerIntegrationTestingPackageVersion>0.5.0-preview2-32233</MicrosoftAspNetCoreServerIntegrationTestingPackageVersion>
12+
<MicrosoftAspNetCoreServerIntegrationTestingPackageVersion>0.5.0-a-preview3-deployment-parameters-scheme-16978</MicrosoftAspNetCoreServerIntegrationTestingPackageVersion>
1313
<MicrosoftAspNetCoreServerKestrelHttpsPackageVersion>2.1.0-preview3-32233</MicrosoftAspNetCoreServerKestrelHttpsPackageVersion>
1414
<MicrosoftAspNetCoreServerKestrelPackageVersion>2.1.0-preview3-32233</MicrosoftAspNetCoreServerKestrelPackageVersion>
1515
<MicrosoftAspNetCoreStaticFilesPackageVersion>2.1.0-preview3-32233</MicrosoftAspNetCoreStaticFilesPackageVersion>

test/Microsoft.AspNetCore.WebSockets.ConformanceTest/Autobahn/AutobahnTester.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ public void Verify(AutobahnResult result)
129129

130130
public async Task DeployTestAndAddToSpec(ServerType server, bool ssl, string environment, CancellationToken cancellationToken, Action<AutobahnExpectations> expectationConfig = null)
131131
{
132-
var baseUrl = ssl ? "https://localhost:0" : "http://localhost:0";
133132
var sslNamePart = ssl ? "SSL" : "NoSSL";
134133
var name = $"{server}|{sslNamePart}|{environment}";
135134
var logger = _loggerFactory.CreateLogger($"AutobahnTestApp:{server}:{sslNamePart}:{environment}");
@@ -146,7 +145,7 @@ public async Task DeployTestAndAddToSpec(ServerType server, bool ssl, string env
146145
#endif
147146
var parameters = new DeploymentParameters(appPath, server, RuntimeFlavor.CoreClr, RuntimeArchitecture.x64)
148147
{
149-
ApplicationBaseUriHint = baseUrl,
148+
Scheme = (ssl ? Uri.UriSchemeHttps : Uri.UriSchemeHttp),
150149
ApplicationType = ApplicationType.Portable,
151150
TargetFramework = targetFramework,
152151
EnvironmentName = environment,

0 commit comments

Comments
 (0)