remove module_to_file query

Author: carljm

crates/red_knot/src/module.rs

@@ -231,11 +231,6 @@ pub struct ModuleData {
 // Queries
 //////////////////////////////////////////////////////
 
-#[tracing::instrument(level = "debug", skip(db))]
-pub fn module_to_file(db: &dyn SemanticDb, module: Module) -> QueryResult<FileId> {
-    Ok(module.path(db)?.file())
-}
-
 /// Resolves a module name to a module id
 /// TODO: This would not work with Salsa because `ModuleName` isn't an ingredient and, therefore, cannot be used as part of a query.
 ///  For this to work with salsa, it would be necessary to intern all `ModuleName`s.

crates/red_knot/src/symbols.rs

@@ -18,7 +18,7 @@ use crate::ast_ids::{NodeKey, TypedNodeKey};
 use crate::cache::KeyValueCache;
 use crate::db::{QueryResult, SemanticDb, SemanticJar};
 use crate::files::FileId;
-use crate::module::{module_to_file, resolve_module, ModuleName};
+use crate::module::{resolve_module, ModuleName};
 use crate::parse::parse;
 use crate::Name;
 
@@ -41,7 +41,7 @@ pub fn resolve_global_symbol(
     let Some(typing_module) = resolve_module(db, module)? else {
         return Ok(None);
     };
-    let typing_file = module_to_file(db, typing_module)?;
+    let typing_file = typing_module.path(db)?.file();
     let typing_table = symbol_table(db, typing_file)?;
     let Some(typing_override) = typing_table.root_symbol_id_by_name(name) else {
         return Ok(None);