[flake8-bugbear] Add async-lru and aiocache decorators to the B019 rule checker #16450
Conversation
|
| /// - [don't lru_cache methods!](https://www.youtube.com/watch?v=sVjtp6tGo0g) | ||
| #[derive(ViolationMetadata)] | ||
| pub(crate) struct CachedInstanceMethod; | ||
| pub(crate) struct CachedInstanceMethod { | ||
| decorator_name: String, |
There was a problem hiding this comment.
Nit: I'd suggest using an enum here to avoid unnecessary String allocation
#[derive(Copy, Clone, Deubg)]
enum LruDecorator {
FuncToolsLruCache,
FunctoolsCache,
AsyncLru,
AiocacheCached,
AiocacheCachedStampede,
AiocacheMultiCached
}
impl LruDecorator {
fn from_qualified_name(name: &[str]) -> Option<Self> {
match qualified_name.segments() {
["functools", "lru_cache"] => Some(Self::FunctoolsLruCache),
...
_ => None,
}
}
impl std::fmt::Display for LruDecorator {
fn fmt(f: &mut std::fmt::Formatter) -> std::fmt::Result {
match self {
Self::FuncToolsLruCache => f.write_str("functools.lru_cache"),
...
}
}
}There was a problem hiding this comment.
Oh, really, thanks!
I used to think about allocation
| /// Returns `Some(<decorator_name>)` if the given expression is one of the known | ||
| /// cache decorators, otherwise `None`. | ||
| fn get_cache_decorator_name(expr: &Expr, semantic: &SemanticModel) -> Option<String> { | ||
| if let Some(qualified_name) = semantic.resolve_qualified_name(expr) { |
There was a problem hiding this comment.
We have to gate this new behavior behind preview mode because it's a considerable extension of the rule's intent (checker.settings().preview.is_enabled())
There was a problem hiding this comment.
I don't understand how to write insta tests in this case, could you explain it to me or give an example?
Hello! Here the download statistics for these two: It seems that |
LuckySting
force-pushed
the
extend-flake8-bugbear-with-async-decorators
branch
3 times, most recently
from
88febe6 to
9a5d515
Compare
LuckySting
force-pushed
the
extend-flake8-bugbear-with-async-decorators
branch
from
9a5d515 to
218755f
Compare
|
@zanieb, do you know how popular/recommended these libraries are in the Python ecosystem? E.g. are they as popular as |
Summary
Resolves #16436.
This change adds support for checking the
B019rule against async cache decorators from the two most commonly used third-party libraries (aiocache and async-lru). It also updates the error message to clearly indicate which decorator was used.Test Plan
cargo nextest runandcargo insta test.