Add to dependency-groups.dev in uv add --dev

Author: charliermarsh

crates/uv/src/commands/project/add.rs

@@ -21,7 +21,7 @@ use uv_distribution::DistributionDatabase;
 use uv_distribution_types::{Index, IndexName, UnresolvedRequirement, VersionId};
 use uv_fs::Simplified;
 use uv_git::{GitReference, GIT_STORE};
-use uv_normalize::PackageName;
+use uv_normalize::{PackageName, DEV_DEPENDENCIES};
 use uv_pep508::{ExtraName, Requirement, UnnamedRequirement, VersionOrUrl};
 use uv_pypi_types::{redact_credentials, ParsedUrl, RequirementSource, VerbatimParsedUrl};
 use uv_python::{
@@ -463,8 +463,32 @@ pub(crate) async fn add(
             _ => source,
         };
 
+        // Determine the dependency type.
+        let dependency_type = match &dependency_type {
+            DependencyType::Production => DependencyType::Production,
+            DependencyType::Optional(extra) => DependencyType::Optional(extra.clone()),
+            // If the requirement already exists in `dev-dependencies`; use that. Otherwise,
+            // use `dependency-groups.dev`.
+            DependencyType::Dev => {
+                if toml.find_dependency(&requirement.name, None).is_empty() {
+                    DependencyType::Group(DEV_DEPENDENCIES.clone())
+                } else {
+                    DependencyType::Dev
+                }
+            }
+            DependencyType::Group(group) => {
+                if group == &*DEV_DEPENDENCIES
+                    && !toml.find_dependency(&requirement.name, None).is_empty()
+                {
+                    DependencyType::Dev
+                } else {
+                    DependencyType::Group(group.clone())
+                }
+            }
+        };
+
         // Update the `pyproject.toml`.
-        let edit = match dependency_type {
+        let edit = match &dependency_type {
             DependencyType::Production => toml.add_dependency(&requirement, source.as_ref())?,
             DependencyType::Dev => toml.add_dev_dependency(&requirement, source.as_ref())?,
             DependencyType::Optional(ref extra) => {
@@ -478,7 +502,7 @@ pub(crate) async fn add(
         // If the edit was inserted before the end of the list, update the existing edits.
         if let ArrayEdit::Add(index) = &edit {
             for edit in &mut edits {
-                if *edit.dependency_type == dependency_type {
+                if edit.dependency_type == dependency_type {
                     match &mut edit.edit {
                         ArrayEdit::Add(existing) => {
                             if *existing >= *index {
@@ -496,7 +520,7 @@ pub(crate) async fn add(
         }
 
         edits.push(DependencyEdit {
-            dependency_type: &dependency_type,
+            dependency_type,
             requirement,
             source,
             edit,
@@ -646,7 +670,7 @@ pub(crate) async fn add(
 async fn lock_and_sync(
     mut project: VirtualProject,
     toml: &mut PyProjectTomlMut,
-    edits: &[DependencyEdit<'_>],
+    edits: &[DependencyEdit],
     venv: &PythonEnvironment,
     state: SharedState,
     locked: bool,
@@ -983,8 +1007,8 @@ impl Target {
 }
 
 #[derive(Debug, Clone)]
-struct DependencyEdit<'a> {
-    dependency_type: &'a DependencyType,
+struct DependencyEdit {
+    dependency_type: DependencyType,
     requirement: Requirement,
     source: Option<Source>,
     edit: ArrayEdit,

crates/uv/src/commands/project/remove.rs

@@ -9,6 +9,7 @@ use uv_configuration::{
     Concurrency, DevGroupsManifest, EditableMode, ExtrasSpecification, InstallOptions, LowerBound,
 };
 use uv_fs::Simplified;
+use uv_normalize::DEV_DEPENDENCIES;
 use uv_pep508::PackageName;
 use uv_python::{PythonDownloads, PythonPreference, PythonRequest};
 use uv_scripts::Pep723Script;
@@ -106,11 +107,13 @@ pub(crate) async fn remove(
                 }
             }
             DependencyType::Dev => {
-                let deps = toml.remove_dev_dependency(&package)?;
-                if deps.is_empty() {
+                let dev_deps = toml.remove_dev_dependency(&package)?;
+                let group_deps =
+                    toml.remove_dependency_group_requirement(&package, &DEV_DEPENDENCIES)?;
+                if dev_deps.is_empty() && group_deps.is_empty() {
                     warn_if_present(&package, &toml);
                     anyhow::bail!(
-                        "The dependency `{package}` could not be found in `dev-dependencies`"
+                        "The dependency `{package}` could not be found in `dev-dependencies` or `dependency-groups.dev`"
                     );
                 }
             }
@@ -124,12 +127,24 @@ pub(crate) async fn remove(
                 }
             }
             DependencyType::Group(ref group) => {
-                let deps = toml.remove_dependency_group_requirement(&package, group)?;
-                if deps.is_empty() {
-                    warn_if_present(&package, &toml);
-                    anyhow::bail!(
-                        "The dependency `{package}` could not be found in `dependency-groups`"
-                    );
+                if group == &*DEV_DEPENDENCIES {
+                    let dev_deps = toml.remove_dev_dependency(&package)?;
+                    let group_deps =
+                        toml.remove_dependency_group_requirement(&package, &DEV_DEPENDENCIES)?;
+                    if dev_deps.is_empty() && group_deps.is_empty() {
+                        warn_if_present(&package, &toml);
+                        anyhow::bail!(
+                            "The dependency `{package}` could not be found in `dev-dependencies` or `dependency-groups.dev`"
+                        );
+                    }
+                } else {
+                    let deps = toml.remove_dependency_group_requirement(&package, group)?;
+                    if deps.is_empty() {
+                        warn_if_present(&package, &toml);
+                        anyhow::bail!(
+                            "The dependency `{package}` could not be found in `dependency-groups`"
+                        );
+                    }
                 }
             }
         }
@@ -262,8 +277,10 @@ fn warn_if_present(name: &PackageName, pyproject: &PyProjectTomlMut) {
                     "`{name}` is an optional dependency; try calling `uv remove --optional {group}`",
                 );
             }
-            DependencyType::Group(_) => {
-                // TODO(zanieb): Once we support `remove --group`, add a warning here.
+            DependencyType::Group(group) => {
+                warn_user!(
+                    "`{name}` is a dependency in the `{group}` group; try calling `uv remove --group {group}`",
+                );
             }
         }
     }