Refuse to remove non-virtual environments in uv venv

Author: charliermarsh

crates/uv-virtualenv/src/lib.rs

@@ -1,10 +1,11 @@
 use std::io;
-use std::path::Path;
+use std::path::{Path, PathBuf};
 
 use thiserror::Error;
 
 use uv_preview::Preview;
 use uv_python::{Interpreter, PythonEnvironment};
+use uv_fs::{Simplified};
 
 pub use virtualenv::{OnExisting, remove_virtualenv};
 
@@ -20,6 +21,8 @@ pub enum Error {
     NotFound(String),
     #[error(transparent)]
     Python(#[from] uv_python::managed::Error),
+    #[error("The directory at `{}` is not a virtual environment; remove it manually to proceed", _0.user_display())]
+    NonVirtualEnvironment(PathBuf),
 }
 
 /// The value to use for the shell prompt when inside a virtual environment.

crates/uv-virtualenv/src/virtualenv.rs

@@ -110,7 +110,8 @@ pub(crate) fn create(
             );
         }
         Ok(metadata) if metadata.is_dir() => {
-            let name = if uv_fs::is_virtualenv_base(location) {
+            let is_virtualenv = uv_fs::is_virtualenv_base(location);
+            let name = if is_virtualenv {
                 "virtual environment"
             } else {
                 "directory"
@@ -120,6 +121,11 @@ pub(crate) fn create(
                     debug!("Allowing existing {name} due to `--allow-existing`");
                 }
                 OnExisting::Remove => {
+                    // Refuse to remove a non-virtual environment, even if `--clear` is provided.
+                    if !is_virtualenv {
+                        return Err(Error::NonVirtualEnvironment(location.to_path_buf()));
+                    }
+
                     debug!("Removing existing {name} due to `--clear`");
                     // Before removing the virtual environment, we need to canonicalize the path
                     // because `Path::metadata` will follow the symlink but we're still operating on
@@ -131,6 +137,11 @@ pub(crate) fn create(
                     fs::create_dir_all(&location)?;
                 }
                 OnExisting::Fail => {
+                    // Refuse to remove a non-virtual environment.
+                    if !is_virtualenv {
+                        return Err(Error::NonVirtualEnvironment(location.to_path_buf()));
+                    }
+
                     match confirm_clear(location, name)? {
                         Some(true) => {
                             debug!("Removing existing {name} due to confirmation");