Skip to content

Commit f44aba0

Browse files
authored
Run the Docker build workflow when we touch project or toolchain metadata (#11938)
I noticed that #11936 did not run the Docker builds, nor did #11934 We should run these when the relevant files change so there aren't surprises at release time! Updates the `build-binaries` workflow to include toolchain version changes and `.cargo/config.toml` changes too.
1 parent c072c9a commit f44aba0

2 files changed

Lines changed: 17 additions & 2 deletions

File tree

‎.github/workflows/build-binaries.yml‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,15 @@ on:
1414
type: string
1515
pull_request:
1616
paths:
17-
# When we change project metadata, we want to ensure that the maturin builds still work.
17+
# We want to ensure that the maturin builds still work when we change
18+
# Project metadata
1819
- pyproject.toml
1920
- Cargo.toml
21+
- .cargo/config.toml
22+
# Toolchain or dependency versions
2023
- Cargo.lock
21-
# And when we change this workflow itself...
24+
- rust-toolchain.toml
25+
# And the workflow itself
2226
- .github/workflows/build-binaries.yml
2327

2428
concurrency:

‎.github/workflows/build-docker.yml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,17 @@ on:
1515
type: string
1616
pull_request:
1717
paths:
18+
# We want to ensure that the maturin builds still work when we change
19+
# Project metadata
20+
- pyproject.toml
21+
- Cargo.toml
22+
- .cargo/config.toml
23+
# Toolchain or dependency versions
24+
- Cargo.lock
25+
- rust-toolchain.toml
26+
# The Dockerfile itself
27+
- Dockerfile
28+
# And the workflow itself
1829
- .github/workflows/build-docker.yml
1930

2031
env:

0 commit comments

Comments
 (0)