Small improvements for re-imports (#600)

* Simplify the check for directory contents.

* Mandate auto-generated provenance fields.

* Don't need to check kwargs

Author: delucchi-cmu

src/hats/catalog/dataset/table_properties.py

@@ -366,4 +366,4 @@ def _estimate_dir_size(target_dir):
         properties["hats_estsize"] = int(_estimate_dir_size(path) / 1024) if path else 0
         properties["hats_release_date"] = "2025-08-22"
         properties["hats_version"] = "v1.0"
-        return properties | kwargs
+        return kwargs | properties

src/hats/io/file_io/file_pointer.py

@@ -152,4 +152,5 @@ def directory_has_contents(pointer: str | Path | UPath) -> bool:
         True if there are any files or subdirectories below this directory.
     """
     pointer = get_upath(pointer)
-    return len(find_files_matching_path(pointer, "*")) > 0
+
+    return next(pointer.rglob("*"), None) is not None

tests/hats/catalog/dataset/test_table_properties.py

@@ -202,13 +202,13 @@ def test_provenance_dict(small_sky_dir, tmp_path):
     contents = ",".join(load_text_file(tmp_path / "hats.properties"))
     assert "\\" not in contents
 
-    # Test that we can override a property and add another.
+    # Test that we can add other properties, but not override auto-generated ones.
     properties = TableProperties.new_provenance_dict(
         small_sky_dir, builder="lsdb v0.1", hats_estsize=1000, foo="bar"
     )
     assert properties["hats_builder"] == f"lsdb v0.1, hats v{version('hats')}"
     assert properties["hats_creation_date"].startswith("20")
-    assert properties["hats_estsize"] == 1000
+    assert properties["hats_estsize"] != 1000
     assert properties["hats_release_date"].startswith("20")
     assert properties["hats_version"].startswith("v")
     assert properties["foo"] == "bar"