clean up file from tests, make logic simpler in download_file

Use temp directory in test

Author: snbianco

astroquery/mast/observations.py

@@ -535,7 +535,7 @@ def download_file(self, uri, *, local_path=None, base_url=None, cache=True, clou
         # parse a local file path from local_path parameter.  Use current directory as default.
         filename = os.path.basename(uri)
         if not local_path:  # local file path is not defined
-            local_path = os.path.join(os.path.abspath('.'), filename)
+            local_path = filename
         elif os.path.isdir(local_path):  # local file path is directory
             local_path = os.path.join(local_path, filename)  # append filename
 

astroquery/mast/tests/test_mast.py

@@ -498,7 +498,8 @@ def test_observations_download_products(patch_post, tmpdir):
 
     # passing row product
     products = mast.Observations.get_product_list('2003738726')
-    result1 = mast.Observations.download_products(products[0])
+    result1 = mast.Observations.download_products(products[0],
+                                                  download_dir=str(tmpdir))
     assert isinstance(result1, Table)
 
 

astroquery/mast/tests/test_mast_remote.py

@@ -405,12 +405,16 @@ def test_observations_download_file(self, tmp_path):
 =======
         assert os.path.exists(Path(os.getcwd(), filename))
 <<<<<<< HEAD
+<<<<<<< HEAD
 =======
         Path.unlink(filename)  # clean up file
 >>>>>>> a8615f1f (space before comment)
 =======
         assert os.path.exists(Path(os.getcwd(), filename))
 >>>>>>> 8033190f (update changes file, add to test case)
+=======
+        Path.unlink(filename) # clean up file
+>>>>>>> 4013186e (clean up file from tests, make logic simpler in download_file)
 
         # download with directory as local_path parameter
         local_path = Path(tmp_path, filename)