Log info if there are download duplicates for MAST

Author: jdavies-st

astroquery/exceptions.py

@@ -7,9 +7,8 @@
 
 __all__ = ['TimeoutError', 'InvalidQueryError', 'RemoteServiceError',
            'TableParseError', 'LoginError', 'ResolverError',
-           'NoResultsWarning', 'DuplicateResultsWarning', 'LargeQueryWarning',
-           'InputWarning', 'AuthenticationWarning', 'MaxResultsWarning',
-           'CorruptDataWarning']
+           'NoResultsWarning', 'LargeQueryWarning', 'InputWarning',
+           'AuthenticationWarning', 'MaxResultsWarning', 'CorruptDataWarning']
 
 
 class TimeoutError(Exception):
@@ -68,13 +67,6 @@ class NoResultsWarning(AstropyWarning):
     pass
 
 
-class DuplicateResultsWarning(AstropyWarning):
-    """
-    Astroquery warning class to be issued when a query returns no result.
-    """
-    pass
-
-
 class LargeQueryWarning(AstropyWarning):
     """
     Astroquery warning class to be issued when a query is larger than

astroquery/mast/observations.py

@@ -31,8 +31,8 @@
 from ..utils import commons, async_to_sync
 from ..utils.class_or_instance import class_or_instance
 from ..exceptions import (TimeoutError, InvalidQueryError, RemoteServiceError,
-                          ResolverError, MaxResultsWarning, DuplicateResultsWarning,
-                          NoResultsWarning, InputWarning, AuthenticationWarning)
+                          ResolverError, MaxResultsWarning, NoResultsWarning,
+                          InputWarning, AuthenticationWarning)
 
 from . import conf, utils
 from .core import MastQueryWithLogin
@@ -827,8 +827,8 @@ def _remove_duplicate_products(self, data_products):
         unique_products = unique(data_products, keys="dataURI")
         number_unique = len(unique_products)
         if number_unique < number:
-            warnings.warn(f"{number - number_unique} of {number} products were duplicates."
-                          f"Only downloading {number_unique} unique product(s).", DuplicateResultsWarning)
+            log.info(f"{number - number_unique} of {number} products were duplicates. "
+                          f"Only downloading {number_unique} unique product(s).")
 
         return unique_products
 

astroquery/mast/tests/test_mast_remote.py

@@ -15,7 +15,7 @@
 
 from ..utils import ResolverError
 from ...exceptions import (InvalidQueryError, MaxResultsWarning, NoResultsWarning,
-                           DuplicateResultsWarning, RemoteServiceError)
+                           RemoteServiceError)
 
 
 OBSID = '1647157'
@@ -290,7 +290,7 @@ def test_observations_download_products(self, tmpdir):
         assert os.path.isfile(result2['Local Path'][0])
         assert len(result2) == 1
 
-    def test_observations_download_products_no_duplicates(tmpdir):
+    def test_observations_download_products_no_duplicates(self, tmpdir, caplog):
 
         # Pull products for a JWST NIRSpec MSA observation with 6 known
         # duplicates of the MSA configuration file, propID=2736
@@ -303,20 +303,21 @@ def test_observations_download_products_no_duplicates(tmpdir):
         assert len(products) == 6
 
         # Download the product
-        with pytest.warns(DuplicateResultsWarning):
-            manifest = mast.Observations.download_products(products,
-                                                           download_dir=str(tmpdir))
+        manifest = mast.Observations.download_products(products,
+                                                       download_dir=str(tmpdir))
 
         # Check that it downloads the MSA config file only once
         assert len(manifest) == 1
 
+        # Check that an INFO message about duplicates was logged
+        with caplog.at_level("INFO", logger="astroquery"):
+            assert "products were duplicates" in caplog.text
+
         # enable access to public AWS S3 bucket
         mast.Observations.enable_cloud_dataset()
 
         # Check duplicate cloud URIs as well
-        with pytest.warns(DuplicateResultsWarning):
-            uris = mast.Observations.get_cloud_uris(products)
-
+        uris = mast.Observations.get_cloud_uris(products)
         assert len(uris) == 1
 
     def test_observations_download_file(self, tmpdir):