Skip to content

Please don't pull in wasm dependencies (via gloo-timers) on non-wasm platforms #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshtriplett opened this issue Aug 26, 2020 · 6 comments

Comments

@joshtriplett
Copy link
Contributor

async-std with the unstable feature enabled pulls in various wasm-specific dependencies via the gloo-timers dependency of futures-timer, even on non-wasm platforms. This adds quite a few dependencies, and shows up when building tide.

@yoshuawuyts
Copy link
Contributor

@joshtriplett agreed; we should fix that.

@e00E
Copy link

e00E commented Aug 28, 2020

When I looked into this I was confused why this happens because in Cargo.toml it looks like the features are separated per target. I think it is related to rust-lang/cargo#1197 .

@jbr
Copy link
Contributor

jbr commented Aug 28, 2020

Possible fix at #864 doesn't rely on target-specific features and switches to a wasm feature, which would be semver-major for wasm users.

As far as I can tell, this issue also ends up interfering with the alloc feature

@Fishrock123
Copy link
Member

See also this older duplicate issue: #823

@dignifiedquire
Copy link
Member

fixed on master

@K4rakara
Copy link

K4rakara commented Jul 4, 2022

gloo-timers is still enabled by default, thus pulling in all of the wasm dependencies unless you go out of your way to use default-features = false and all the other features manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants