arguments keyword not being matched

[smaili]

Screenshot:

[Victorystick]

Not an issue as such. arguments isn't a keyword. https://people.mozilla.org/~jorendorff/es6-draft.html#sec-keywords

[smaili]

@Victorystick, that's a reference to the ES6 draft. I believe ES5 treats arguments as a keyword, or at the very least a reserved word.

[Victorystick]

Nope. ES5 spec: https://es5.github.io/#x7.8.4

ES6 didn't remove anything.

[mehcode]

Shouldn't arguments at least be a support.* something or other? It might not be a keyword but its certainly a "language feature".

[smaili]

I stand corrected. They seem to refer to it as an "identifier" :)

In any case, I don't see anything wrong with having some kind of group matching to at least give highlighters the opportunity to stylize it if they so choose.

[smaili]

Maybe also add constructor and prototype to the list?

[winstliu]

constructor

Please see #191 for more details (basically, it's already tokenized, but some themes don't colorize it).

[smaili]

@50Wliu You seem to be on to something. The same happens to delete.

[YurySolovyov]

I agree that arguments need some more specialized highlighting, it would make it easier to spot it in code.

[winstliu]

All right. Coming back to this: Does anyone have any suggestions for what arguments should be tokenized as?

[YurySolovyov]

@50Wliu IMO same as this - kind of metavariable.

[MaximSokolov]

variable.language.arguments