Complete switch from JSHint to ESLint

Convert all the JSHint rules to the ESLint equivalents where possible.
The no-undef rule in ESLint caught a few cases of undefined usages in
the tests, so they were also fixed.

Author: MitMaro

.eslintrc.json

@@ -1,8 +1,23 @@
 {
+  "root": true,
+  "parserOptions": {
+    "ecmaVersion": 6
+  },
   "env": {
-    "es6": true
+    "es6": true,
+    "node": true
   },
   "rules": {
-    "indent": [2,2]
+    "comma-style": "error",
+    "dot-notation": "error",
+    "indent": ["error", 2],
+    "no-control-regex": "error",
+    "no-div-regex": "error",
+    "no-eval": "error",
+    "no-implied-eval": "error",
+    "no-invalid-regexp": "error",
+    "no-trailing-spaces": "error",
+    "no-undef": "error",
+    "no-unused-vars": "error"
   }
-}
+}

.jshintrc

@@ -0,0 +1,5 @@
+{
+  "env": {
+    "mocha": true
+  }
+}

test/.eslintrc.json

@@ -19,14 +19,14 @@ describe('signing a token asynchronously', function() {
     });
 
     it('should work with empty options', function (done) {
-      jwt.sign({abc: 1}, "secret", {}, function (err, res) {
+      jwt.sign({abc: 1}, "secret", {}, function (err) {
         expect(err).to.be.null();
         done();
       });
     });
 
     it('should work without options object at all', function (done) {
-      jwt.sign({abc: 1}, "secret", function (err, res) {
+      jwt.sign({abc: 1}, "secret", function (err) {
         expect(err).to.be.null();
         done();
       });

test/async_sign.tests.js

@@ -1,6 +1,5 @@
 var jwt = require('../index');
 var expect = require('chai').expect;
-var atob = require('atob');
 
 describe('decoding', function() {
 

test/decoding.tests.js

@@ -1,13 +1,12 @@
 var jwt = require('../index');
 var expect = require('chai').expect;
-var assert = require('chai').assert;
 
 describe('invalid expiration', function() {
 
   it('should fail with string', function (done) {
     var broken_token = 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJleHAiOiIxMjMiLCJmb28iOiJhZGFzIn0.cDa81le-pnwJMcJi3o3PBwB7cTJMiXCkizIhxbXAKRg';
 
-    jwt.verify(broken_token, '123', function (err, decoded) {
+    jwt.verify(broken_token, '123', function (err) {
       expect(err.name).to.equal('JsonWebTokenError');
       done();
     });

test/invalid_exp.tests.js

@@ -4,35 +4,35 @@ var expect = require('chai').expect;
 describe('issue 304 - verifying values other than strings', function() {
 
   it('should fail with numbers', function (done) {
-    jwt.verify(123, 'foo', function (err, decoded) {
+    jwt.verify(123, 'foo', function (err) {
       expect(err.name).to.equal('JsonWebTokenError');
       done();
     });
   });
 
   it('should fail with objects', function (done) {
-    jwt.verify({ foo: 'bar' }, 'biz', function (err, decoded) {
+    jwt.verify({ foo: 'bar' }, 'biz', function (err) {
       expect(err.name).to.equal('JsonWebTokenError');
       done();
     });
   });
 
   it('should fail with arrays', function (done) {
-    jwt.verify(['foo'], 'bar', function (err, decoded) {
+    jwt.verify(['foo'], 'bar', function (err) {
       expect(err.name).to.equal('JsonWebTokenError');
       done();
     });
   });
 
   it('should fail with functions', function (done) {
-    jwt.verify(function() {}, 'foo', function (err, decoded) {
+    jwt.verify(function() {}, 'foo', function (err) {
       expect(err.name).to.equal('JsonWebTokenError');
       done();
     });
   });
 
   it('should fail with booleans', function (done) {
-    jwt.verify(true, 'foo', function (err, decoded) {
+    jwt.verify(true, 'foo', function (err) {
       expect(err.name).to.equal('JsonWebTokenError');
       done();
     });

test/issue_304.tests.js

@@ -102,7 +102,7 @@ describe('HS256', function() {
 
     it('should return the "invalid token" error', function(done) {
       var malformedToken = token + ' '; // corrupt the token by adding a space
-      jwt.verify(malformedToken, secret, { algorithm: 'HS256', ignoreExpiration: true }, function(err, decoded) {
+      jwt.verify(malformedToken, secret, { algorithm: 'HS256', ignoreExpiration: true }, function(err) {
         assert.isNotNull(err);
         assert.equal('JsonWebTokenError', err.name);
         assert.equal('invalid token', err.message);

test/jwt.hs.tests.js

@@ -1,4 +1,3 @@
-var fs = require('fs');
 var jwt = require('../index');
 var JsonWebTokenError = require('../lib/JsonWebTokenError');
 var expect = require('chai').expect;

test/undefined_secretOrPublickey.tests.js

@@ -308,7 +308,7 @@ describe('verify', function() {
       var clockTimestamp = 1000000000;
       it('should verify unexpired token relative to user-provided clockTimestamp', function (done) {
         var token = jwt.sign({foo: 'bar', iat: clockTimestamp, exp: clockTimestamp + 1}, key);
-        jwt.verify(token, key, {clockTimestamp: clockTimestamp}, function (err, p) {
+        jwt.verify(token, key, {clockTimestamp: clockTimestamp}, function (err) {
           assert.isNull(err);
           done();
         });
@@ -340,7 +340,7 @@ describe('verify', function() {
           nbf: clockTimestamp + 1,
           exp: clockTimestamp + 2
         }, key);
-        jwt.verify(token, key, {clockTimestamp: clockTimestamp + 1}, function (err, p) {
+        jwt.verify(token, key, {clockTimestamp: clockTimestamp + 1}, function (err) {
           assert.isNull(err);
           done();
         });