Skip to content

Update to syn 0.12 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KodrAus opened this issue Jan 21, 2018 · 3 comments
Closed

Update to syn 0.12 #8

KodrAus opened this issue Jan 21, 2018 · 3 comments

Comments

@KodrAus
Copy link
Member

KodrAus commented Jan 21, 2018

So we can report errors much more better using spans to the actual code that prevents auto_impl from being valid.

@LukasKalbertodt
Copy link
Member

Hi @KodrAus,

I just wanted to let you know that I'm working on a syn update by rewriting the crate, basically. First I just tried to update it to the new version incrementally, but I noticed that quite a lot has happened since this crate was written. Thus, updating wasn't that easy and would have required a lot of cleanup. So I figured I could just try to rewrite it.

I'm already like... half done, approximately. Should be done in the next few days.

Would you (in principle) accept a PR like that?

@KodrAus
Copy link
Member Author

KodrAus commented Jul 4, 2018

Hi @LukasKalbertodt! Wow that sounds great to me! I'd be more than happy to just give you the commit bit so you can push changes through if you'd like.

I'm really interested to see what an implementation using syn 0.12 looks like.

@LukasKalbertodt
Copy link
Member

@KodrAus I'd prefer to create a PR and having someone to at least quickly skim over the new code. But thanks for invitation anyway. I'm sure there are more updates needed before the proc_macro system hits stable :P

And if this wasn't clear: I upgraded to the newest version of syn (0.14.4), quote (0.6.3) and proc_macro2 (0.4.6). But yes, I think the new implementation will look a lot different than the old one.

I'll open a PR once I'm finished!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants