Skip to content

[refactor] Getting the dataset properties directly from the dataset class #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ravinkohli opened this issue Mar 26, 2021 · 0 comments
Closed
Assignees
Labels
refactoring Improvement of readability and abstract codes

Comments

@ravinkohli
Copy link
Contributor

ravinkohli commented Mar 26, 2021

Currently we have 2 functions get_dataset_requirements and then dataset.get_required_properties (see here). We can unify them into a single function that will directly return all the required properties from the dataset. This would be especially useful in the abstract_evaluator as it can reduce the clutter here

@ravinkohli ravinkohli added the refactoring Improvement of readability and abstract codes label Mar 26, 2021
@ravinkohli ravinkohli self-assigned this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improvement of readability and abstract codes
Projects
None yet
Development

No branches or pull requests

1 participant