linting

Author: TheEimer

hydra_plugins/hyper_smac/hyper_smac.py

@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-from copy import deepcopy
 from pathlib import Path
 
 import pandas as pd
@@ -65,11 +64,12 @@ def ask(self):
                 optimizer_termination = True
                 print("All brackets finished. Optimization will terminate.")
 
-            if not self.brackets_finished:
-                if self.total_configs >= sum(self.smac._intensifier._n_configs_in_stage[self.current_bracket]):
-                    self.current_bracket += 1
-                    self.total_configs = 0
-                    terminate = True
+            if not self.brackets_finished and self.total_configs >= sum(
+                self.smac._intensifier._n_configs_in_stage[self.current_bracket]
+            ):
+                self.current_bracket += 1
+                self.total_configs = 0
+                terminate = True
 
         return info, terminate, optimizer_termination
 

hydra_plugins/hypersweeper/hypersweeper_sweeper.py

@@ -472,7 +472,7 @@ def run(self, verbose=False):
 
                 try:
                     pass
-                    #info, terminate, optimizer_termination = self.optimizer.ask()
+                    # info, terminate, optimizer_termination = self.optimizer.ask()
                 except Exception as e:  # noqa: BLE001
                     if len(infos) > 0:
                         print("Optimizer failed on ask - running remaining configs.")

tests/test_runs/test_smac.py

@@ -50,7 +50,7 @@ def test_smac_hyperband_termination():
     # Goal: first launch 13 jobs in bracket 1, then 6 in bracket 2, then 3 in bracket 3, then 2 and terminate
     keyword = "Launching "
     all_keyword_indices = [m.start() for m in re.finditer(keyword, process_logs)]
-    n_jobs_spawned = [int(process_logs[occ + len(keyword):occ + len(keyword)+2]) for occ in all_keyword_indices]
+    n_jobs_spawned = [int(process_logs[occ + len(keyword) : occ + len(keyword) + 2]) for occ in all_keyword_indices]
     total_jobs_spawned = sum(n_jobs_spawned)
 
     assert total_jobs_spawned == 20, (
@@ -68,6 +68,7 @@ def test_smac_hyperband_termination():
 
     shutil.rmtree(Path("mlp_smac_hyperband"))
 
+
 def test_smac_hyperband_optimizer_termination():
     if Path("mlp_smac_hyperband").exists():
         shutil.rmtree(Path("mlp_smac_hyperband"))
@@ -88,13 +89,11 @@ def test_smac_hyperband_optimizer_termination():
     # Goal: first launch 13 jobs in bracket 1, then 6 in bracket 2, then 3 in bracket 3, then 2 and terminate
     keyword = "Launching "
     all_keyword_indices = [m.start() for m in re.finditer(keyword, process_logs)]
-    n_jobs_spawned = [int(process_logs[occ + len(keyword):occ + len(keyword)+2]) for occ in all_keyword_indices]
+    n_jobs_spawned = [int(process_logs[occ + len(keyword) : occ + len(keyword) + 2]) for occ in all_keyword_indices]
     total_jobs_spawned = sum(n_jobs_spawned)
     print(n_jobs_spawned)
 
-    assert total_jobs_spawned == 23, (
-        f"Optimizer termination not happening. Used: {total_jobs_spawned}, expected: 23."
-    )
+    assert total_jobs_spawned == 23, f"Optimizer termination not happening. Used: {total_jobs_spawned}, expected: 23."
     assert n_jobs_spawned[0] == 13, (
         f"Number of spawned jobs in bracket 1 is incorrect. Used: {n_jobs_spawned[0]}, expected: 13."
     )