Skip to content

Commit 5be58fb

Browse files
authored
Merge pull request #857 from avaje/feature/ScopeInfo-genericRequires
ScopeInfo providesString & requiresString to use generic types only
2 parents 0e49924 + 7e3b8be commit 5be58fb

File tree

1 file changed

+6
-6
lines changed
  • inject-generator/src/main/java/io/avaje/inject/generator

1 file changed

+6
-6
lines changed

inject-generator/src/main/java/io/avaje/inject/generator/ScopeInfo.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,8 @@ void buildAtInjectModule(Append writer) {
393393
writer.append(Constants.AT_GENERATED).eol();
394394
writer.append("@InjectModule(");
395395
boolean leadingComma = false;
396-
List<String> regularProvides = new ArrayList<>();
397-
List<String> genericProvides = new ArrayList<>();
396+
Set<String> regularProvides = new LinkedHashSet<>();
397+
Set<String> genericProvides = new LinkedHashSet<>();
398398

399399
for (var type : provides) {
400400
if (type.contains("<")) {
@@ -409,12 +409,12 @@ void buildAtInjectModule(Append writer) {
409409
leadingComma = true;
410410
}
411411
if (!genericProvides.isEmpty()) {
412-
attributeString(false, writer, "providesString", provides);
412+
attributeString(false, writer, "providesString", genericProvides);
413413
leadingComma = true;
414414
}
415415

416-
List<String> regularRequires = new ArrayList<>();
417-
List<String> genericRequires = new ArrayList<>();
416+
Set<String> regularRequires = new LinkedHashSet<>();
417+
Set<String> genericRequires = new LinkedHashSet<>();
418418

419419
for (var type : requires) {
420420
if (type.contains("<")) {
@@ -428,7 +428,7 @@ void buildAtInjectModule(Append writer) {
428428
leadingComma = true;
429429
}
430430
if (!genericRequires.isEmpty()) {
431-
attributeString(leadingComma, writer, "requiresString", requires);
431+
attributeString(leadingComma, writer, "requiresString", genericRequires);
432432
leadingComma = true;
433433
}
434434
if (!requiresPackages.isEmpty()) {

0 commit comments

Comments
 (0)