Skip to content

Commit 12c50c7

Browse files
author
Thomas
committed
Reverted changes done to babel-config.js. Enabled chalk and colors in cli.js test and pass the --color flag for the babel config test
1 parent 84e6e8e commit 12c50c7

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

lib/babel-config.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
'use strict';
22
const path = require('path');
3+
const chalk = require('chalk');
34
const figures = require('figures');
45
const convertSourceMap = require('convert-source-map');
6+
const colors = require('./colors');
57

68
function validate(conf) {
79
if (conf === undefined || conf === null) {
@@ -12,9 +14,9 @@ function validate(conf) {
1214
const isValidShortcut = conf === 'default' || conf === 'inherit';
1315

1416
if (!conf || (typeof conf === 'string' && !isValidShortcut)) {
15-
let message = figures.cross;
17+
let message = colors.error(figures.cross);
1618
message += ' Unexpected Babel configuration for AVA. ';
17-
message += 'See https://github.com/avajs/ava#es2015-support for allowed values.';
19+
message += 'See ' + chalk.underline('https://github.com/avajs/ava#es2015-support') + ' for allowed values.';
1820

1921
throw new Error(message);
2022
}

test/cli.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,15 @@ const proxyquire = require('proxyquire');
1212
const sinon = require('sinon');
1313
const uniqueTempDir = require('unique-temp-dir');
1414
const execa = require('execa');
15+
const colors = require('../lib/colors');
1516

1617
const cliPath = path.join(__dirname, '../cli.js');
1718

1819
// For some reason chalk is disabled by default
1920
chalk.enabled = true;
21+
for (const key of Object.keys(colors)) {
22+
colors[key].enabled = true;
23+
}
2024

2125
function execCli(args, opts, cb) {
2226
let dirname;
@@ -70,12 +74,12 @@ function execCli(args, opts, cb) {
7074
}
7175

7276
test('disallow invalid babel config shortcuts', t => {
73-
execCli('es2015.js', {dirname: 'fixture/invalid-babel-config'}, (err, stdout, stderr) => {
77+
execCli(['--color', 'es2015.js'], {dirname: 'fixture/invalid-babel-config'}, (err, stdout, stderr) => {
7478
t.ok(err);
7579

7680
let expectedOutput = '\n ';
77-
expectedOutput += figures.cross + ' Unexpected Babel configuration for AVA.';
78-
expectedOutput += ' See https://github.com/avajs/ava#es2015-support for allowed values.';
81+
expectedOutput += colors.error(figures.cross) + ' Unexpected Babel configuration for AVA.';
82+
expectedOutput += ' See ' + chalk.underline('https://github.com/avajs/ava#es2015-support') + ' for allowed values.';
7983
expectedOutput += '\n';
8084

8185
t.is(stderr, expectedOutput);

0 commit comments

Comments
 (0)