Skip to content

Commit af30e73

Browse files
committed
Remove dead code and obsolete TODOs
1 parent 6ed3ad1 commit af30e73

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

lib/glob-helpers.cjs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,9 @@ function normalizeFileForMatching(cwd, file) {
9797
file = slash(file);
9898
}
9999

100-
if (!cwd) { // TODO: Ensure tests provide an actual value.
101-
return file;
102-
}
103-
104-
// TODO: If `file` is outside `cwd` we can't normalize it. Need to figure
105-
// out if that's a real-world scenario, but we may have to ensure the file
106-
// isn't even selected.
100+
// Note that if `file` is outside `cwd` we can't normalize it. If this turns
101+
// out to be a real-world scenario we may have to make changes in calling code
102+
// to make sure the file isn't even selected for matching.
107103
if (!file.startsWith(cwd)) {
108104
return file;
109105
}

lib/worker/base.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ const run = async options => {
3939
process.exit(); // eslint-disable-line unicorn/no-process-exit
4040
}
4141

42-
// TODO: Initialize providers here, then pass to lineNumberSelection() so they
43-
// can be used to parse the test file.
4442
let checkSelectedByLineNumbers;
4543
try {
4644
checkSelectedByLineNumbers = lineNumberSelection({

test/snapshot-regenerate-report/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ test('snapshot report can be regenerated from .snap file', async t => {
3737
});
3838

3939
// Regenerate report
40-
snapshots.hasChanges = true; // TODO this is a hack
40+
snapshots.hasChanges = true; // Force.
4141
snapshots.save();
4242

4343
// Assert that reports match

0 commit comments

Comments
 (0)