Skip to content

Debug serially in the "Debugging tests with VS Code" recipe #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 17, 2018
Merged

Debug serially in the "Debugging tests with VS Code" recipe #1634

merged 5 commits into from
Jan 17, 2018

Conversation

troysandal
Copy link
Contributor

Debug serially to avoid confusing execution paths in async code, e.g. swapping from one test's execution context to the next.

Debug serially to avoid confusing execution paths in async code, e.g. swapping from one test's execution context to the next.
@novemberborn
Copy link
Member

Thanks for your PR @troysandal! Those execution paths may be the cause of test failures, though. Rather than suggesting this as the default invocation, perhaps you could repeat the configurations section with the --serial flag included, and a brief explanation of why this might be useful?

@troysandal
Copy link
Contributor Author

@novemberborn great point Mark, I added a new section under Debug that addresses this, thank you.

@novemberborn
Copy link
Member

Thanks @troysandal. I've made a few more changes, please let me know if you're happy with them.

@sindresorhus sindresorhus changed the title debug serially Debug serially in the "Debugging tests with VS Code" recipe Jan 17, 2018
@troysandal
Copy link
Contributor Author

Changes look great @novemberborn and @sindresorhus thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants