Skip to content

wip - Support compilation of "helper" modules#177

Closed
jamestalmage wants to merge 2 commits into
avajs:masterfrom
jamestalmage:transitive-require
Closed

wip - Support compilation of "helper" modules#177
jamestalmage wants to merge 2 commits into
avajs:masterfrom
jamestalmage:transitive-require

Conversation

@jamestalmage
Copy link
Copy Markdown
Contributor

This solves the basic requirements of #156.

It relies on floatdrop/require-from-string#3

Along the way I uncovered a few other bugs that should get fixed in master (I will call those out in line comments).

// @floatdrop

Comment thread lib/babel.js Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldTranspile definitely needs to be improved. Very naive.

I'm holding off investing time on it until we have a decision what the API and CLI should look like.

Comment thread lib/babel.js
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldTranspile method definitely needs to be improved. Very naive.

I'm holding off investing time on it until we have a decision what the API and CLI should look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant