no-nested-tests: Fix false positive on tests following a nested pair

Author: sindresorhus

rules/no-nested-tests.js

@@ -6,28 +6,27 @@ const MESSAGE_ID = 'no-nested-tests';
 
 const create = context => {
 	const ava = createAvaRule();
-	let nestedCount = 0;
+	const testNodeStack = [];
 
 	return ava.merge({
 		CallExpression: visitIf([
 			ava.isInTestFile,
 			ava.isTestNode,
 		])(node => {
-			nestedCount++;
-			if (nestedCount >= 2) {
+			testNodeStack.push(node);
+			if (testNodeStack.length >= 2) {
 				context.report({
 					node,
 					messageId: MESSAGE_ID,
 				});
 			}
 		}),
 
-		'CallExpression:exit': visitIf([
-			ava.isInTestFile,
-			ava.isTestNode,
-		])(() => {
-			nestedCount--;
-		}),
+		'CallExpression:exit'(node) {
+			if (testNodeStack.length > 0 && testNodeStack.at(-1) === node) {
+				testNodeStack.pop();
+			}
+		},
 	});
 };
 

test/no-async-fn-without-await.js

@@ -130,7 +130,7 @@ ruleTester.run('no-async-fn-without-await', rule, {
 				}],
 			}],
 		},
-		// for-await-of inside nested function does not count
+		// `for-await-of` inside nested function does not count
 		{
 			code: 'test(async t => { async function helper() { for await (const x of gen()) {} } });',
 			errors: [{

test/no-nested-tests.js

@@ -33,5 +33,20 @@ ruleTester.run('no-nested-tests', rule, {
 			code: 'test(t => { test(t => { test(t => {}); }); });',
 			errors: [error, error],
 		},
+		{
+			// The standalone test after the nested pair must not be a false positive
+			code: 'test(t => { test(t => {}); }); test(t => {});',
+			errors: [error],
+		},
+		{
+			// Multiple subsequent tests after a nested pair must not be false positives
+			code: 'test(t => { test(t => {}); }); test(t => {}); test(t => {});',
+			errors: [error],
+		},
+		{
+			// Two sequential nested pairs followed by a valid test must not accumulate state
+			code: 'test(t => { test(t => {}); }); test(t => { test(t => {}); }); test(t => {});',
+			errors: [error, error],
+		},
 	],
 });