Remove enhance-visitors dependency

sindresorhus · andreww2012 · sindresorhus · commit a867c898cadd · 2026-05-20T03:04:50.000+07:00
Closes #362 Co-authored-by: Andrew Kazakov <6554045+andreww2012@users.noreply.github.com>
diff --git a/create-ava-rule.js b/create-ava-rule.js
@@ -1,5 +1,4 @@
 /* eslint-disable eslint-plugin/prefer-message-ids, eslint-plugin/prefer-object-rule, eslint-plugin/require-meta-docs-description, eslint-plugin/require-meta-docs-recommended, eslint-plugin/require-meta-schema, eslint-plugin/require-meta-type */
-import enhance from 'enhance-visitors';
 import {findVariable} from '@eslint-community/eslint-utils';
 import {hasComputedTestModifier, unwrapTypeExpression} from './util.js';
 
@@ -17,6 +16,32 @@ const trackedAliasModifiers = new Set([
 	'todo',
 ]);
 
+const mergeVisitors = (...visitors) => {
+	const visitor = {};
+
+	for (const customVisitor of visitors) {
+		for (const [selector, customHandler] of Object.entries(customVisitor)) {
+			const predefinedHandler = visitor[selector];
+			if (!predefinedHandler) {
+				visitor[selector] = customHandler;
+				continue;
+			}
+
+			visitor[selector] = selector.endsWith(':exit')
+				? node => {
+					customHandler(node);
+					predefinedHandler(node);
+				}
+				: node => {
+					predefinedHandler(node);
+					customHandler(node);
+				};
+		}
+	}
+
+	return visitor;
+};
+
 const createAvaRule = sourceCode => {
 	let isTestFile = false;
 	let currentTestNode;
@@ -194,8 +219,14 @@ const createAvaRule = sourceCode => {
 		isInTestFile: () => isTestFile,
 		isInTestNode: () => currentTestNode,
 		isTestNode: node => currentTestNode === node,
-		merge: customHandlers => enhance.mergeVisitors([predefinedRules, customHandlers]),
+		merge: customHandlers => mergeVisitors(predefinedRules, customHandlers),
 	};
 };
 
+export const visitIf = predicates => visitor => node => {
+	if (predicates.every(predicate => predicate(node))) {
+		return visitor(node);
+	}
+};
+
 export default createAvaRule;
diff --git a/package.json b/package.json
@@ -44,7 +44,6 @@
 	"dependencies": {
 		"@eslint-community/eslint-utils": "^4.9.1",
 		"@eslint/json": "^1.0.0",
-		"enhance-visitors": "^1.0.0",
 		"espree": "^11.1.0",
 		"espurify": "^3.2.0",
 		"micro-spelling-correcter": "^1.1.1",
diff --git a/rules/assertion-arguments.js b/rules/assertion-arguments.js
@@ -1,9 +1,8 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import {
 	getStaticValue, isOpeningParenToken, isCommaToken, findVariable,
 } from '@eslint-community/eslint-utils';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID_TOO_FEW = 'too-few-arguments';
 const MESSAGE_ID_TOO_MANY = 'too-many-arguments';
diff --git a/rules/failing-test-url.js b/rules/failing-test-url.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'failing-test-url';
diff --git a/rules/hooks-order.js b/rules/hooks-order.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'hooks-order';
diff --git a/rules/max-asserts.js b/rules/max-asserts.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'max-asserts';
 
diff --git a/rules/no-async-fn-without-await.js b/rules/no-async-fn-without-await.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'no-async-fn-without-await';
diff --git a/rules/no-conditional-assertion.js b/rules/no-conditional-assertion.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'no-conditional-assertion';
diff --git a/rules/no-duplicate-hooks.js b/rules/no-duplicate-hooks.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'no-duplicate-hooks';
diff --git a/rules/no-duplicate-modifiers.js b/rules/no-duplicate-modifiers.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-duplicate-modifiers';
 
diff --git a/rules/no-identical-title.js b/rules/no-identical-title.js
@@ -1,8 +1,7 @@
 import {isDeepStrictEqual} from 'node:util';
 import espurify from 'espurify';
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-identical-title';
 
diff --git a/rules/no-ignored-test-files.js b/rules/no-ignored-test-files.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID_HELPER = 'helper-file';
 const MESSAGE_ID_IGNORED = 'ignored-file';
diff --git a/rules/no-incorrect-deep-equal.js b/rules/no-incorrect-deep-equal.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-deep-equal-with-primitive';
 
diff --git a/rules/no-inline-assertions.js b/rules/no-inline-assertions.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'no-inline-assertions';
diff --git a/rules/no-invalid-modifier-chain.js b/rules/no-invalid-modifier-chain.js
@@ -1,7 +1,6 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import {findVariable} from '@eslint-community/eslint-utils';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-invalid-modifier-chain';
 const SUGGESTION_MESSAGE_ID = 'no-invalid-modifier-chain-suggestion';
diff --git a/rules/no-negated-assertion.js b/rules/no-negated-assertion.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-negated-assertion';
 
diff --git a/rules/no-nested-assertions.js b/rules/no-nested-assertions.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'no-nested-assertions';
diff --git a/rules/no-nested-tests.js b/rules/no-nested-tests.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'no-nested-tests';
diff --git a/rules/no-only-test.js b/rules/no-only-test.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'no-only-test';
diff --git a/rules/no-skip-assert.js b/rules/no-skip-assert.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-skip-assert';
 const MESSAGE_ID_SUGGESTION = 'no-skip-assert-suggestion';
diff --git a/rules/no-skip-test.js b/rules/no-skip-test.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'no-skip-test';
diff --git a/rules/no-todo-implementation.js b/rules/no-todo-implementation.js
@@ -1,7 +1,6 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import {isCommaToken} from '@eslint-community/eslint-utils';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-todo-implementation';
 const MESSAGE_ID_REMOVE_TODO = 'no-todo-implementation-remove-todo';
diff --git a/rules/no-todo-test.js b/rules/no-todo-test.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'no-todo-test';
diff --git a/rules/no-unknown-modifiers.js b/rules/no-unknown-modifiers.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-unknown-modifiers';
 const MESSAGE_ID_SUGGESTION = 'no-unknown-modifiers-suggestion';
diff --git a/rules/no-useless-t-pass.js b/rules/no-useless-t-pass.js
@@ -1,7 +1,6 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import {findVariable} from '@eslint-community/eslint-utils';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-useless-t-pass';
 
diff --git a/rules/prefer-async-await.js b/rules/prefer-async-await.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import {findVariable} from '@eslint-community/eslint-utils';
-import createAvaRule from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'prefer-async-await';
diff --git a/rules/prefer-power-assert.js b/rules/prefer-power-assert.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'prefer-power-assert';
diff --git a/rules/prefer-t-regex.js b/rules/prefer-t-regex.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'prefer-t-regex';
diff --git a/rules/prefer-t-throws.js b/rules/prefer-t-throws.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID_SYNC = 'prefer-t-throws';
diff --git a/rules/require-assertion.js b/rules/require-assertion.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import {findVariable} from '@eslint-community/eslint-utils';
-import createAvaRule from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'require-assertion';
diff --git a/rules/test-title-format.js b/rules/test-title-format.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'test-title-format';
diff --git a/rules/test-title.js b/rules/test-title.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import {findVariable} from '@eslint-community/eslint-utils';
-import createAvaRule from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID_MISSING = 'test-title';
diff --git a/rules/use-t-throws-async-well.js b/rules/use-t-throws-async-well.js
@@ -1,6 +1,5 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'use-t-throws-async-well';
 
diff --git a/rules/use-t-well.js b/rules/use-t-well.js
@@ -1,7 +1,6 @@
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import MicroSpellingCorrecter from 'micro-spelling-correcter';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID_NOT_FUNCTION = 'not-function';
 const MESSAGE_ID_UNKNOWN_ASSERTION = 'unknown-assertion';
diff --git a/rules/use-t.js b/rules/use-t.js
@@ -1,5 +1,4 @@
-import {visitIf} from 'enhance-visitors';
-import createAvaRule from '../create-ava-rule.js';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
 
 const MESSAGE_ID = 'use-t';
diff --git a/rules/use-true-false.js b/rules/use-true-false.js
@@ -1,9 +1,8 @@
 import {isDeepStrictEqual} from 'node:util';
 import * as espree from 'espree';
 import espurify from 'espurify';
-import {visitIf} from 'enhance-visitors';
+import createAvaRule, {visitIf} from '../create-ava-rule.js';
 import util from '../util.js';
-import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID_TRUE = 'use-true';
 const MESSAGE_ID_FALSE = 'use-false';
