Skip to content

Commit 930850f

Browse files
authored
K8S_NAMESPACE -> ACK_SYSTEM_NAMESPACE (#290)
This is the patch that corresponds to changes made to ACK runtime to rename the `K8S_NAMESPACE` environment variable to `ACK_SYSTEM_NAMESPACE` to better represent what this variable referred to. Related: aws-controllers-k8s/runtime#72 Related: aws-controllers-k8s/community#1178 Issue: aws-controllers-k8s/community#1173 Signed-off-by: Jay Pipes <[email protected]> By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent cd3ad28 commit 930850f

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ GO111MODULE=on
66
AWS_SERVICE=$(shell echo $(SERVICE) | tr '[:upper:]' '[:lower:]')
77

88
# Build ldflags
9-
VERSION ?= "v0.16.5"
9+
VERSION ?= "v0.17.0"
1010
GITCOMMIT=$(shell git rev-parse HEAD)
1111
BUILDDATE=$(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
1212
IMPORT_PATH=github.com/aws-controllers-k8s/code-generator

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/aws-controllers-k8s/code-generator
33
go 1.17
44

55
require (
6-
github.com/aws-controllers-k8s/runtime v0.16.5
6+
github.com/aws-controllers-k8s/runtime v0.17.0
77
github.com/aws/aws-sdk-go v1.42.0
88
github.com/dlclark/regexp2 v1.4.0
99
// pin to v0.1.1 due to release problem with v0.1.2

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5 h1:0CwZNZbxp69SHPd
9090
github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5/go.mod h1:wHh0iHkYZB8zMSxRWpUBQtwG5a7fFgvEO+odwuTv2gs=
9191
github.com/asaskevich/govalidator v0.0.0-20180720115003-f9ffefc3facf/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
9292
github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
93-
github.com/aws-controllers-k8s/runtime v0.16.5 h1:1eRU1s0DaduaZcktzG+jUNwPYW+ouKGe7ciAeNNW/2g=
94-
github.com/aws-controllers-k8s/runtime v0.16.5/go.mod h1:9c2CL3w0BlVkse+foHlP1SkJRqYWLs9H+4X/z+2kE3w=
93+
github.com/aws-controllers-k8s/runtime v0.17.0 h1:6gIU65BfD9K7cf9jrfs8hVMOWwRMNrmErYC4QsIER0w=
94+
github.com/aws-controllers-k8s/runtime v0.17.0/go.mod h1:9c2CL3w0BlVkse+foHlP1SkJRqYWLs9H+4X/z+2kE3w=
9595
github.com/aws/aws-sdk-go v1.42.0 h1:BMZws0t8NAhHFsfnT3B40IwD13jVDG5KerlRksctVIw=
9696
github.com/aws/aws-sdk-go v1.42.0/go.mod h1:585smgzpB/KqRA+K3y/NL/oYRqQvpNJYvLm+LY1U59Q=
9797
github.com/benbjohnson/clock v1.0.3/go.mod h1:bGMdMPoPVvcYyt1gHDf4J2KE153Yf9BuiUKYMaxlTDM=

templates/config/controller/deployment.yaml.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ spec:
4949
cpu: 100m
5050
memory: 200Mi
5151
env:
52-
- name: K8S_NAMESPACE
52+
- name: ACK_SYSTEM_NAMESPACE
5353
valueFrom:
5454
fieldRef:
5555
fieldPath: metadata.namespace

templates/helm/templates/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ spec:
5757
resources:
5858
{{- toYaml .Values.resources | nindent 10 }}
5959
env:
60-
- name: K8S_NAMESPACE
60+
- name: ACK_SYSTEM_NAMESPACE
6161
valueFrom:
6262
fieldRef:
6363
fieldPath: metadata.namespace

0 commit comments

Comments
 (0)