Skip to content

Maintenance: Restore functionality of existing end-to-end tests #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
phipag opened this issue Apr 2, 2025 · 2 comments · Fixed by #1816
Closed
1 of 2 tasks

Maintenance: Restore functionality of existing end-to-end tests #1815

phipag opened this issue Apr 2, 2025 · 2 comments · Fixed by #1816
Assignees
Labels
bug Something isn't working governance maintenance v2 Version 2

Comments

@phipag
Copy link
Contributor

phipag commented Apr 2, 2025

Summary

Currently, the end-to-end tests do not work. It seems that the infrastructure cannot be created in the AWS account due to some issues with bootstrapping the account/CDK stack. Since we don't deploy using CDK but only synthesize CloudFormation using CDK, maybe there is some incompatibility.

Current error:

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 14.41 s <<< FAILURE! -- in software.amazon.lambda.powertools.MetricsE2ET
[ERROR] software.amazon.lambda.powertools.MetricsE2ET -- Time elapsed: 14.41 s <<< ERROR!
software.amazon.awssdk.services.cloudformation.model.CloudFormationException: Unable to fetch parameters [/cdk-bootstrap/hnb659fds/version] from parameter store for this account. (Service: CloudFormation, Status Code: 400, Request ID: 2bcf84dd-75e3-4f7b-83fc-4f93f6f0e0c0)

It also seems that some of the test assertions were not updated with features added to the library or AWS services at a later point after initial implementation. For example, AWS X-RAY creates a default "Init" trace for Lambda functions now which is ignored in this assertion: https://github.com/aws-powertools/powertools-lambda-java/blob/v2/powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/TracingE2ET.java#L79.

The goal of this issue is to:

  • Restore the infrastructure creation process of the end-to-end tests
  • Fix all bugs in all end-to-tests (e.g. failing assertions)

Why is this needed?

Restoring the functionality of end-to-end tests is crucial to assure the functionality of the library at runtime and achieve a safe release process.

Which area does this relate to?

No response

Solution

No response

Acknowledgment

@phipag phipag added this to the v2 milestone Apr 2, 2025
@phipag phipag self-assigned this Apr 2, 2025
@phipag phipag moved this from Triage to Backlog in Powertools for AWS Lambda (Java) Apr 2, 2025
@phipag phipag moved this from Backlog to Working on it in Powertools for AWS Lambda (Java) Apr 2, 2025
@phipag phipag added the bug Something isn't working label Apr 2, 2025
@phipag phipag linked a pull request Apr 2, 2025 that will close this issue
4 tasks
@phipag
Copy link
Contributor Author

phipag commented Apr 2, 2025

Created PR #1816

@phipag phipag moved this from Working on it to Pending review in Powertools for AWS Lambda (Java) Apr 2, 2025
@phipag
Copy link
Contributor Author

phipag commented Apr 7, 2025

PR merged into v2 branch.

@phipag phipag closed this as completed Apr 7, 2025
@phipag phipag moved this from Pending review to Shipped in Powertools for AWS Lambda (Java) Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working governance maintenance v2 Version 2
Projects
Status: Shipped
1 participant