Skip to content

Commit 7a141a5

Browse files
committed
Fix backwards compatibility test
1 parent 7e663c5 commit 7a141a5

File tree

2 files changed

+35
-10
lines changed

2 files changed

+35
-10
lines changed

.github/actions/setup-integration-test/action.yml

Lines changed: 34 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ inputs:
2121
required: false
2222
description: "The AWS Role Session Name"
2323
default: ""
24+
browser-compatibility-test:
25+
required: false
26+
description: "Determines if this job is running as a browser compatibility test"
27+
default: false
2428
outputs:
2529
integ_test_required:
2630
description: "Whether integration tests are required based on changes"
@@ -48,19 +52,25 @@ runs:
4852
npm install ../../amazon-chime-sdk-js-$current_version.tgz
4953
shell: bash
5054
- name: Configure AWS Credentials
51-
if: steps.test_needed.outputs.integ_test_required == 'true'
55+
if: |
56+
steps.test_needed.outputs.integ_test_required == 'true' ||
57+
inputs.browser-compatibility-test == 'true'
5258
uses: aws-actions/configure-aws-credentials@v4
5359
with:
5460
role-to-assume: ${{ inputs.aws-role-to-assume }}
5561
role-session-name: ${{ inputs.aws-role-session-name }}
5662
aws-region: us-east-1
5763
- name: Setup Node.js - 20.x
58-
if: steps.test_needed.outputs.integ_test_required == 'true'
64+
if: |
65+
steps.test_needed.outputs.integ_test_required == 'true' ||
66+
inputs.browser-compatibility-test == 'true'
5967
uses: actions/setup-node@v3
6068
with:
6169
node-version: 20.x
6270
- name: Check if SauceLabs credentials are provided
63-
if: steps.test_needed.outputs.integ_test_required == 'true'
71+
if: |
72+
steps.test_needed.outputs.integ_test_required == 'true' ||
73+
inputs.browser-compatibility-test == 'true'
6474
id: check-sauce
6575
run: |
6676
if [ -n "${{ inputs.sauce-username }}" ] && [ -n "${{ inputs.sauce-access-key }}" ]; then
@@ -70,19 +80,27 @@ runs:
7080
fi
7181
shell: bash
7282
- name: Create a Job ID for SauceLabs
73-
if: steps.test_needed.outputs.integ_test_required == 'true' && steps.check-sauce.outputs.use_sauce == 'true'
83+
if: |
84+
(steps.test_needed.outputs.integ_test_required == 'true' || inputs.browser-compatibility-test == 'true')
85+
&& steps.check-sauce.outputs.use_sauce == 'true'
7486
id: create-job-id
7587
uses: filipstefansson/uuid-action@ce29ebbb0981ac2448c2e406e848bfaa30ddf04c
7688
- name: Set JOB_ID Env Variable for SauceLabs
77-
if: steps.test_needed.outputs.integ_test_required == 'true' && steps.check-sauce.outputs.use_sauce == 'true'
89+
if: |
90+
(steps.test_needed.outputs.integ_test_required == 'true' || inputs.browser-compatibility-test == 'true')
91+
&& steps.check-sauce.outputs.use_sauce == 'true'
7892
run: echo "JOB_ID=${{ steps.create-job-id.outputs.uuid }}" >> $GITHUB_ENV
7993
shell: bash
8094
- name: Echo Job ID for SauceLabs
81-
if: steps.test_needed.outputs.integ_test_required == 'true' && steps.check-sauce.outputs.use_sauce == 'true'
95+
if: |
96+
(steps.test_needed.outputs.integ_test_required == 'true' || inputs.browser-compatibility-test == 'true')
97+
&& steps.check-sauce.outputs.use_sauce == 'true'
8298
run: echo "${{ steps.create-job-id.outputs.uuid }}"
8399
shell: bash
84100
- name: Setup Sauce Connect
85-
if: steps.test_needed.outputs.integ_test_required == 'true' && steps.check-sauce.outputs.use_sauce == 'true'
101+
if: |
102+
(steps.test_needed.outputs.integ_test_required == 'true' || inputs.browser-compatibility-test == 'true')
103+
&& steps.check-sauce.outputs.use_sauce == 'true'
86104
uses: saucelabs/[email protected]
87105
with:
88106
username: ${{ inputs.sauce-username }}
@@ -91,16 +109,22 @@ runs:
91109
region: us
92110
proxyLocalhost: direct
93111
- name: Setup Chrome for local testing
94-
if: steps.test_needed.outputs.integ_test_required == 'true' && steps.check-sauce.outputs.use_sauce == 'false'
112+
if: |
113+
steps.test_needed.outputs.integ_test_required == 'true' &&
114+
steps.check-sauce.outputs.use_sauce == 'false'
95115
uses: browser-actions/setup-chrome@latest
96116
with:
97117
chrome-version: stable
98118
- name: Clean Install
99-
if: steps.test_needed.outputs.integ_test_required == 'true'
119+
if: |
120+
steps.test_needed.outputs.integ_test_required == 'true' ||
121+
inputs.browser-compatibility-test == 'true'
100122
run: npm ci
101123
shell: bash
102124
- name: Add testsite host to /etc/hosts for Linux only (fixes 500 internal error when loading the test page)
103125
shell: bash
104-
if: steps.test_needed.outputs.integ_test_required == 'true' && runner.os == 'Linux'
126+
if: |
127+
(steps.test_needed.outputs.integ_test_required == 'true' || inputs.browser-compatibility-test == 'true') &&
128+
runner.os == 'Linux'
105129
run: |
106130
sudo echo "127.0.0.1 testsite" | sudo tee -a /etc/hosts

.github/workflows/browser-compatibility-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ jobs:
3737
aws-role-session-name: ${{ env.TEST_TYPE }}
3838
sauce-username: ${{ secrets.SAUCE_USERNAME }}
3939
sauce-access-key: ${{ secrets.SAUCE_ACCESS_KEY }}
40+
browser-compatibility-test: true
4041
- name: Run Audio Test
4142
working-directory: ./integration/mocha-tests
4243
run: npm run test -- --test-name AudioTest --host saucelabs --test-type browser-compatibility

0 commit comments

Comments
 (0)