Skip to content

Commit f2b4eff

Browse files
authored
fix(secretsmanager): SecretRotation app does not set DeletionPolicy (#20901)
Internal Amazon campaigns are validating that all `AWS::Serverless::Application` resources have `DeletionPolicy` set. Since `AWS::Serverless::Application` is not classified as a stateful resource by our metadata (nor could/should it be, because who knows?) we don't benefit from the automatic support for these policies from our model. Instead, manually add the required `Delete` policies on the `CfnApplication`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 4e52091 commit f2b4eff

File tree

26 files changed

+156
-632
lines changed

26 files changed

+156
-632
lines changed

packages/@aws-cdk/aws-docdb/test/cluster-rotation.lit.integ.snapshot/aws-cdk-docdb-cluster-rotation.template.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,9 @@
672672
},
673673
"excludeCharacters": "\"@/"
674674
}
675-
}
675+
},
676+
"UpdateReplacePolicy": "Delete",
677+
"DeletionPolicy": "Delete"
676678
}
677679
},
678680
"Mappings": {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"version":"17.0.0"}
1+
{"version":"20.0.0"}

packages/@aws-cdk/aws-docdb/test/cluster-rotation.lit.integ.snapshot/integ.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"version": "18.0.0",
2+
"version": "20.0.0",
33
"testCases": {
4-
"aws-docdb/test/integ.cluster-rotation.lit": {
4+
"integ.cluster-rotation.lit": {
55
"stacks": [
66
"aws-cdk-docdb-cluster-rotation"
77
],

packages/@aws-cdk/aws-docdb/test/cluster-rotation.lit.integ.snapshot/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "17.0.0",
2+
"version": "20.0.0",
33
"artifacts": {
44
"Tree": {
55
"type": "cdk:tree",

packages/@aws-cdk/aws-docdb/test/cluster-rotation.lit.integ.snapshot/tree.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"id": "Tree",
99
"path": "Tree",
1010
"constructInfo": {
11-
"fqn": "@aws-cdk/core.Construct",
12-
"version": "0.0.0"
11+
"fqn": "constructs.Construct",
12+
"version": "10.1.33"
1313
}
1414
},
1515
"aws-cdk-docdb-cluster-rotation": {

packages/@aws-cdk/aws-rds/test/cluster-rotation.lit.integ.snapshot/aws-cdk-rds-cluster-rotation.template.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,9 @@
694694
},
695695
"excludeCharacters": " %+~`#$&*()|[]{}:;<>?!'/@\"\\"
696696
}
697-
}
697+
},
698+
"UpdateReplacePolicy": "Delete",
699+
"DeletionPolicy": "Delete"
698700
}
699701
},
700702
"Mappings": {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"version":"17.0.0"}
1+
{"version":"20.0.0"}

packages/@aws-cdk/aws-rds/test/cluster-rotation.lit.integ.snapshot/integ.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"version": "18.0.0",
2+
"version": "20.0.0",
33
"testCases": {
4-
"aws-rds/test/integ.cluster-rotation.lit": {
4+
"integ.cluster-rotation.lit": {
55
"stacks": [
66
"aws-cdk-rds-cluster-rotation"
77
],

packages/@aws-cdk/aws-rds/test/cluster-rotation.lit.integ.snapshot/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "17.0.0",
2+
"version": "20.0.0",
33
"artifacts": {
44
"Tree": {
55
"type": "cdk:tree",

packages/@aws-cdk/aws-rds/test/cluster-rotation.lit.integ.snapshot/tree.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"id": "Tree",
99
"path": "Tree",
1010
"constructInfo": {
11-
"fqn": "@aws-cdk/core.Construct",
12-
"version": "0.0.0"
11+
"fqn": "constructs.Construct",
12+
"version": "10.1.33"
1313
}
1414
},
1515
"aws-cdk-rds-cluster-rotation": {

0 commit comments

Comments
 (0)