Fix client context param keys to use snake_case for endpoint resolver lookup

Author: AndrewAsseily

awscli/customizations/clientcontextparams.py

@@ -97,7 +97,7 @@ def _apply_client_context_params(param_defs, session, parsed_args, **kwargs):
         py_name = cli_name.replace('-', '_')
         value = getattr(parsed_args, py_name, None)
         if value is not None:
-            context_params[original_name] = value
+            context_params[xform_name(original_name)] = value
     if not context_params:
         return
     new_config = Config(client_context_params=context_params)

tests/functional/test_clientcontextparams.py

@@ -23,15 +23,15 @@ def test_boolean_flag_sets_client_context_params(self):
         config = self.driver.session.get_default_client_config()
         self.assertEqual(
             config.client_context_params,
-            {'DisableS3ExpressSessionAuth': True},
+            {'disable_s3_express_session_auth': True},
         )
 
     def test_negative_flag_sets_false(self):
         self.run_cmd('s3api list-buckets --no-disable-s3-express-session-auth')
         config = self.driver.session.get_default_client_config()
         self.assertEqual(
             config.client_context_params,
-            {'DisableS3ExpressSessionAuth': False},
+            {'disable_s3_express_session_auth': False},
         )
 
     def test_no_flag_does_not_set_client_context_params(self):

tests/unit/customizations/test_clientcontextparams.py

@@ -122,46 +122,11 @@ def test_unsupported_type_skips_param(argument_table, session):
     assert 'count' not in argument_table
 
 
-def test_registers_operation_args_parsed_handler(argument_table, session):
-    _inject(argument_table, session, [_make_context_param('ForcePathStyle')])
-    event_name = session.register.call_args[0][0]
-    assert event_name == 'operation-args-parsed.s3api.list-buckets'
-
-
 def _apply(session, param_defs, **attr_values):
     parsed_args = argparse.Namespace(**attr_values)
     _apply_client_context_params(param_defs, session, parsed_args)
 
 
-def test_flag_passed_sets_config(session):
-    _apply(
-        session,
-        [('force-path-style', 'ForcePathStyle')],
-        force_path_style=True,
-    )
-    config = session.set_default_client_config.call_args[0][0]
-    assert config.client_context_params == {'ForcePathStyle': True}
-
-
-def test_no_flag_passed_does_not_set_config(session):
-    _apply(
-        session,
-        [('force-path-style', 'ForcePathStyle')],
-        force_path_style=None,
-    )
-    session.set_default_client_config.assert_not_called()
-
-
-def test_negative_flag_sends_false(session):
-    _apply(
-        session,
-        [('force-path-style', 'ForcePathStyle')],
-        force_path_style=False,
-    )
-    config = session.set_default_client_config.call_args[0][0]
-    assert config.client_context_params == {'ForcePathStyle': False}
-
-
 def test_merges_with_existing_config(session):
     session.get_default_client_config.return_value = Config(read_timeout=30)
     _apply(
@@ -170,7 +135,7 @@ def test_merges_with_existing_config(session):
         force_path_style=True,
     )
     config = session.set_default_client_config.call_args[0][0]
-    assert config.client_context_params == {'ForcePathStyle': True}
+    assert config.client_context_params == {'force_path_style': True}
     assert config.read_timeout == 30
 
 
@@ -184,14 +149,3 @@ def test_string_add_to_parser():
     arg.add_to_parser(parser)
     result = parser.parse_args(['--endpoint', 'custom.example.com'])
     assert result.endpoint == 'custom.example.com'
-
-
-def test_add_to_params_is_noop():
-    arg = ClientContextParamArgument(
-        name='force-path-style',
-        context_param_name='ForcePathStyle',
-        param_type='boolean',
-    )
-    params = {}
-    arg.add_to_params(params, True)
-    assert params == {}