chore(go): put back content() in mutable maps extern#1694
Merged
Conversation
We lost context() because content() was our implemented function and when I copied the mutable map from dafny repo I did not realize this.
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
texastony
approved these changes
Aug 21, 2025
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
josecorella
pushed a commit
that referenced
this pull request
Feb 2, 2026
## [1.11.2](v1.11.1...v1.11.2) (2026-02-02) ### Fixes -- DotNet * **dotnet:** build from main ([#1781](#1781)) ([b2d6075](b2d6075)) ### Maintenance -- All Languages * **dafny:** add fuzz testing to MPL ([#1622](#1622)) ([14fad38](14fad38)) * **dafny:** add new SearchAndReplaceWhole and friends ([#1680](#1680)) ([74e98c1](74e98c1)) * **dafny:** bump setup_dafny ([#1712](#1712)) ([2c57523](2c57523)) * **dafny:** optimize mutation map for O(1) performance in Go ([#1687](#1687)) ([68cd7cb](68cd7cb)) ### Maintenance -- Python * **python:** add user agent suffix to kms requests ([#1686](#1686)) ([b69aaf2](b69aaf2)) * **python:** allow local testing ([#1651](#1651)) ([8b221c4](8b221c4)) * **python:** exclude generated tests from project distribution ([#1627](#1627)) ([505eee0](505eee0)) * **python:** tests for OpaqueWithText ([#1656](#1656)) ([25e1219](25e1219)) ### Maintenance -- Go * **go:** add go 1.25 to CI ([#1684](#1684)) ([49aa27c](49aa27c)) * **go:** put back content() in mutable maps extern ([#1694](#1694)) ([bb0ec0c](bb0ec0c)) * **go:** Release dynamodb Go module 0.2.1 ([#1671](#1671)) ([c82e136](c82e136)) * **go:** Release dynamodb Go module 0.2.2 ([#1698](#1698)) ([76846e1](76846e1)) * **go:** Release kms Go module 0.2.1 ([#1667](#1667)) ([dd8cdf1](dd8cdf1)) * **go:** Release kms Go module 0.2.2 ([#1697](#1697)) ([79c0531](79c0531)) * **go:** Release kms Go module 0.3.0 ([#1746](#1746)) ([1e438f3](1e438f3)) * **go:** Release mpl Go module 0.2.1 ([#1672](#1672)) ([9bc43c0](9bc43c0)) * **go:** Release mpl Go module 0.2.2 ([#1704](#1704)) ([5f2aa33](5f2aa33)) * **go:** Release mpl Go module 0.3.0 ([#1751](#1751)) ([1ac31b6](1ac31b6)) * **go:** Release primitives Go module 0.2.1 ([#1669](#1669)) ([dca265f](dca265f)) * **go:** Release primitives Go module 0.2.2 ([#1699](#1699)) ([d4c3a20](d4c3a20)) * **go:** Release primitives Go module 0.3.0 ([#1748](#1748)) ([541e04a](541e04a)) * **go:** Release smithy-dafny-standard-library Go module 0.2.1 ([#1666](#1666)) ([fa3f98b](fa3f98b)) * **go:** Release smithy-dafny-standard-library Go module 0.2.2 ([#1696](#1696)) ([4312195](4312195)) * **go:** remove create pull request step in go release workflow ([#1681](#1681)) ([7eafe88](7eafe88)) * **go:** test with go 1.23 ([#1737](#1737)) ([987ac0f](987ac0f)) * **go:** update Go release script for ESDK and DB-ESDK ([#1653](#1653)) ([ea64f20](ea64f20)) * **go:** update release script ([#1676](#1676)) ([34f9689](34f9689)) * **go:** Update release script to cd to right directory ([#1679](#1679)) ([952c42f](952c42f)) ### Maintenance -- Rust * **rust:** bump dafny version for rust to 4.10 ([#1725](#1725)) ([f41b3c4](f41b3c4)) * **rust:** clean up kms module ([#1752](#1752)) ([6878377](6878377)) * **rust:** fix clippy warning. Bump test dependencies ([#1715](#1715)) ([7b8d6ac](7b8d6ac)) * **rust:** more compatible blocking ([#1780](#1780)) ([3ea1161](3ea1161)) * **rust:** note unused parameter ([#1693](#1693)) ([49759c9](49759c9)) * **rust:** prepare for initial Rust crate publication ([#1755](#1755)) ([1e28a61](1e28a61)) * **rust:** provide fips feature flag ([#1703](#1703)) ([f6bdd23](f6bdd23)) * **rust:** release 0.2.0 ([#1782](#1782)) ([03c999c](03c999c)) * **rust:** remove warnings ([#1724](#1724)) ([453359a](453359a)) ### Miscellaneous * add managed policy to cfn template ([#1758](#1758)) ([81cc558](81cc558)) * Add UserAgent string to KMS client ([#1716](#1716)) ([09b2cda](09b2cda)) * bump CI to macos-14 ([#1734](#1734)) ([1413b88](1413b88)) * bump smithy-dafny ([#1657](#1657)) ([e2fb76c](e2fb76c)) * bump smithy-dafny ([#1706](#1706)) ([dc1678a](dc1678a)) * **CI:** ci action to upload performance logs to cloudwatch ([#1754](#1754)) ([c5b3ac6](c5b3ac6)) * **ci:** Install Go/goimports as codegen dependencies ([#1713](#1713)) ([7a6fd63](7a6fd63)) * **CI:** test DB-ESDK java examples from MPL ([#1692](#1692)) ([4e06e37](4e06e37)) * **CI:** update slack notification to include link of GHA run ([#1659](#1659)) ([c6e2c20](c6e2c20)) * clean up submodule URL to remove embedded username ([#1757](#1757)) ([df1ec90](df1ec90)) * **deps:** bump actions/download-artifact from 4 to 6 in /.github/workflows ([#1747](#1747)) ([2a767e7](2a767e7)) * **deps:** update deps across the repo ([#1773](#1773)) ([edcc64c](edcc64c)) * update check-files ([#1785](#1785)) ([14af920](14af920)) * update kms externs correctly ([#1717](#1717)) ([e11ba53](e11ba53)) * Update workflow permissions ([#1783](#1783)) ([37f416e](37f416e))
josecorella
pushed a commit
that referenced
this pull request
Feb 2, 2026
* **dotnet:** build from main ([#1781](#1781)) ([b2d6075](b2d6075)) * **dafny:** add fuzz testing to MPL ([#1622](#1622)) ([14fad38](14fad38)) * **dafny:** add new SearchAndReplaceWhole and friends ([#1680](#1680)) ([74e98c1](74e98c1)) * **dafny:** bump setup_dafny ([#1712](#1712)) ([2c57523](2c57523)) * **dafny:** optimize mutation map for O(1) performance in Go ([#1687](#1687)) ([68cd7cb](68cd7cb)) * **python:** add user agent suffix to kms requests ([#1686](#1686)) ([b69aaf2](b69aaf2)) * **python:** allow local testing ([#1651](#1651)) ([8b221c4](8b221c4)) * **python:** exclude generated tests from project distribution ([#1627](#1627)) ([505eee0](505eee0)) * **python:** tests for OpaqueWithText ([#1656](#1656)) ([25e1219](25e1219)) * **go:** add go 1.25 to CI ([#1684](#1684)) ([49aa27c](49aa27c)) * **go:** put back content() in mutable maps extern ([#1694](#1694)) ([bb0ec0c](bb0ec0c)) * **go:** Release dynamodb Go module 0.2.1 ([#1671](#1671)) ([c82e136](c82e136)) * **go:** Release dynamodb Go module 0.2.2 ([#1698](#1698)) ([76846e1](76846e1)) * **go:** Release kms Go module 0.2.1 ([#1667](#1667)) ([dd8cdf1](dd8cdf1)) * **go:** Release kms Go module 0.2.2 ([#1697](#1697)) ([79c0531](79c0531)) * **go:** Release kms Go module 0.3.0 ([#1746](#1746)) ([1e438f3](1e438f3)) * **go:** Release mpl Go module 0.2.1 ([#1672](#1672)) ([9bc43c0](9bc43c0)) * **go:** Release mpl Go module 0.2.2 ([#1704](#1704)) ([5f2aa33](5f2aa33)) * **go:** Release mpl Go module 0.3.0 ([#1751](#1751)) ([1ac31b6](1ac31b6)) * **go:** Release primitives Go module 0.2.1 ([#1669](#1669)) ([dca265f](dca265f)) * **go:** Release primitives Go module 0.2.2 ([#1699](#1699)) ([d4c3a20](d4c3a20)) * **go:** Release primitives Go module 0.3.0 ([#1748](#1748)) ([541e04a](541e04a)) * **go:** Release smithy-dafny-standard-library Go module 0.2.1 ([#1666](#1666)) ([fa3f98b](fa3f98b)) * **go:** Release smithy-dafny-standard-library Go module 0.2.2 ([#1696](#1696)) ([4312195](4312195)) * **go:** remove create pull request step in go release workflow ([#1681](#1681)) ([7eafe88](7eafe88)) * **go:** test with go 1.23 ([#1737](#1737)) ([987ac0f](987ac0f)) * **go:** update Go release script for ESDK and DB-ESDK ([#1653](#1653)) ([ea64f20](ea64f20)) * **go:** update release script ([#1676](#1676)) ([34f9689](34f9689)) * **go:** Update release script to cd to right directory ([#1679](#1679)) ([952c42f](952c42f)) * **rust:** bump dafny version for rust to 4.10 ([#1725](#1725)) ([f41b3c4](f41b3c4)) * **rust:** clean up kms module ([#1752](#1752)) ([6878377](6878377)) * **rust:** fix clippy warning. Bump test dependencies ([#1715](#1715)) ([7b8d6ac](7b8d6ac)) * **rust:** more compatible blocking ([#1780](#1780)) ([3ea1161](3ea1161)) * **rust:** note unused parameter ([#1693](#1693)) ([49759c9](49759c9)) * **rust:** prepare for initial Rust crate publication ([#1755](#1755)) ([1e28a61](1e28a61)) * **rust:** provide fips feature flag ([#1703](#1703)) ([f6bdd23](f6bdd23)) * **rust:** release 0.2.0 ([#1782](#1782)) ([03c999c](03c999c)) * **rust:** remove warnings ([#1724](#1724)) ([453359a](453359a)) * add managed policy to cfn template ([#1758](#1758)) ([81cc558](81cc558)) * Add UserAgent string to KMS client ([#1716](#1716)) ([09b2cda](09b2cda)) * bump CI to macos-14 ([#1734](#1734)) ([1413b88](1413b88)) * bump smithy-dafny ([#1657](#1657)) ([e2fb76c](e2fb76c)) * bump smithy-dafny ([#1706](#1706)) ([dc1678a](dc1678a)) * **CI:** ci action to upload performance logs to cloudwatch ([#1754](#1754)) ([c5b3ac6](c5b3ac6)) * **ci:** Install Go/goimports as codegen dependencies ([#1713](#1713)) ([7a6fd63](7a6fd63)) * **CI:** test DB-ESDK java examples from MPL ([#1692](#1692)) ([4e06e37](4e06e37)) * **CI:** update slack notification to include link of GHA run ([#1659](#1659)) ([c6e2c20](c6e2c20)) * clean up submodule URL to remove embedded username ([#1757](#1757)) ([df1ec90](df1ec90)) * **deps:** bump actions/download-artifact from 4 to 6 in /.github/workflows ([#1747](#1747)) ([2a767e7](2a767e7)) * **deps:** update deps across the repo ([#1773](#1773)) ([edcc64c](edcc64c)) * update check-files ([#1785](#1785)) ([14af920](14af920)) * update kms externs correctly ([#1717](#1717)) ([e11ba53](e11ba53)) * Update workflow permissions ([#1783](#1783)) ([37f416e](37f416e))
josecorella
pushed a commit
that referenced
this pull request
Feb 2, 2026
* **dotnet:** build from main ([#1781](#1781)) ([b2d6075](b2d6075)) * **dafny:** add fuzz testing to MPL ([#1622](#1622)) ([14fad38](14fad38)) * **dafny:** add new SearchAndReplaceWhole and friends ([#1680](#1680)) ([74e98c1](74e98c1)) * **dafny:** bump setup_dafny ([#1712](#1712)) ([2c57523](2c57523)) * **dafny:** optimize mutation map for O(1) performance in Go ([#1687](#1687)) ([68cd7cb](68cd7cb)) * **python:** add user agent suffix to kms requests ([#1686](#1686)) ([b69aaf2](b69aaf2)) * **python:** allow local testing ([#1651](#1651)) ([8b221c4](8b221c4)) * **python:** exclude generated tests from project distribution ([#1627](#1627)) ([505eee0](505eee0)) * **python:** tests for OpaqueWithText ([#1656](#1656)) ([25e1219](25e1219)) * **go:** add go 1.25 to CI ([#1684](#1684)) ([49aa27c](49aa27c)) * **go:** put back content() in mutable maps extern ([#1694](#1694)) ([bb0ec0c](bb0ec0c)) * **go:** Release dynamodb Go module 0.2.1 ([#1671](#1671)) ([c82e136](c82e136)) * **go:** Release dynamodb Go module 0.2.2 ([#1698](#1698)) ([76846e1](76846e1)) * **go:** Release kms Go module 0.2.1 ([#1667](#1667)) ([dd8cdf1](dd8cdf1)) * **go:** Release kms Go module 0.2.2 ([#1697](#1697)) ([79c0531](79c0531)) * **go:** Release kms Go module 0.3.0 ([#1746](#1746)) ([1e438f3](1e438f3)) * **go:** Release mpl Go module 0.2.1 ([#1672](#1672)) ([9bc43c0](9bc43c0)) * **go:** Release mpl Go module 0.2.2 ([#1704](#1704)) ([5f2aa33](5f2aa33)) * **go:** Release mpl Go module 0.3.0 ([#1751](#1751)) ([1ac31b6](1ac31b6)) * **go:** Release primitives Go module 0.2.1 ([#1669](#1669)) ([dca265f](dca265f)) * **go:** Release primitives Go module 0.2.2 ([#1699](#1699)) ([d4c3a20](d4c3a20)) * **go:** Release primitives Go module 0.3.0 ([#1748](#1748)) ([541e04a](541e04a)) * **go:** Release smithy-dafny-standard-library Go module 0.2.1 ([#1666](#1666)) ([fa3f98b](fa3f98b)) * **go:** Release smithy-dafny-standard-library Go module 0.2.2 ([#1696](#1696)) ([4312195](4312195)) * **go:** remove create pull request step in go release workflow ([#1681](#1681)) ([7eafe88](7eafe88)) * **go:** test with go 1.23 ([#1737](#1737)) ([987ac0f](987ac0f)) * **go:** update Go release script for ESDK and DB-ESDK ([#1653](#1653)) ([ea64f20](ea64f20)) * **go:** update release script ([#1676](#1676)) ([34f9689](34f9689)) * **go:** Update release script to cd to right directory ([#1679](#1679)) ([952c42f](952c42f)) * **rust:** bump dafny version for rust to 4.10 ([#1725](#1725)) ([f41b3c4](f41b3c4)) * **rust:** clean up kms module ([#1752](#1752)) ([6878377](6878377)) * **rust:** fix clippy warning. Bump test dependencies ([#1715](#1715)) ([7b8d6ac](7b8d6ac)) * **rust:** more compatible blocking ([#1780](#1780)) ([3ea1161](3ea1161)) * **rust:** note unused parameter ([#1693](#1693)) ([49759c9](49759c9)) * **rust:** prepare for initial Rust crate publication ([#1755](#1755)) ([1e28a61](1e28a61)) * **rust:** provide fips feature flag ([#1703](#1703)) ([f6bdd23](f6bdd23)) * **rust:** release 0.2.0 ([#1782](#1782)) ([03c999c](03c999c)) * **rust:** remove warnings ([#1724](#1724)) ([453359a](453359a)) * add managed policy to cfn template ([#1758](#1758)) ([81cc558](81cc558)) * Add UserAgent string to KMS client ([#1716](#1716)) ([09b2cda](09b2cda)) * bump CI to macos-14 ([#1734](#1734)) ([1413b88](1413b88)) * bump smithy-dafny ([#1657](#1657)) ([e2fb76c](e2fb76c)) * bump smithy-dafny ([#1706](#1706)) ([dc1678a](dc1678a)) * **CI:** ci action to upload performance logs to cloudwatch ([#1754](#1754)) ([c5b3ac6](c5b3ac6)) * **ci:** Install Go/goimports as codegen dependencies ([#1713](#1713)) ([7a6fd63](7a6fd63)) * **CI:** test DB-ESDK java examples from MPL ([#1692](#1692)) ([4e06e37](4e06e37)) * **CI:** update slack notification to include link of GHA run ([#1659](#1659)) ([c6e2c20](c6e2c20)) * clean up submodule URL to remove embedded username ([#1757](#1757)) ([df1ec90](df1ec90)) * **deps:** bump actions/download-artifact from 4 to 6 in /.github/workflows ([#1747](#1747)) ([2a767e7](2a767e7)) * **deps:** update deps across the repo ([#1773](#1773)) ([edcc64c](edcc64c)) * update check-files ([#1785](#1785)) ([14af920](14af920)) * update kms externs correctly ([#1717](#1717)) ([e11ba53](e11ba53)) * Update workflow permissions ([#1783](#1783)) ([37f416e](37f416e))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We lost content() because content() was missing in Dafny implementation and when I copied the mutable map from dafny repo I did not realize this.
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.